Fix add bookmark / folder modal in fullscreen #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
requested changes
Jan 16, 2023
There was a problem hiding this comment.
This is so much better in full screen – nice work @graeme!
One bug before this can be merged: the Add Folder view controller doesn't get its addFolderViewControllerWillClose function called, so the popover state never gets reset to transient and thus never closes on its own. Once that's sorted, this is good to go!
You can reproduce this by:
- Open the bookmarks popover (not even in full screen)
- Click the Add Folder button
- Click "Cancel"
- Try to click outside the popover to close it, and notice it won't close
samsymons
added a commit
that referenced
this pull request
Jan 26, 2023
# By Dominik Kapusta (4) and others # Via GitHub * develop: Blockable JS Alerts inside tabs (#904) Fix add bookmark / folder modal in fullscreen (#930) Add Mac App Store target (#927) Pull request review checklist added to the pull request template (#935) Version Bump to 0.31.7 Update embedded files Update BSK with autofill 6.1.2 (#942) Migrate to targeted Swift Concurrency checking (#937) Add bundler configuration to limit Gemfile.lock noise (#939) update openssl depedency (#918) Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938) Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933) Sparkle 2 (#934) Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202138144256919/f
Tech Design URL:
CC:
Description:
Note: This is no longer a problem on Ventura. But this fixes the issue on earlier OS versions
When adding a bookmark via the three dots menu on the top right, while having the browser in full screen, the popup window for adding that bookmark goes fullscreen as well. After finishing, the full screen window stays, but black.
This happens for every modally presented ViewController, not just from the three dot menu.
In most cases, this was fixable by just presenting as a sheet, but for the Add Bookmark / Folder modal from the Bookmarks popover, it a.) needed to be presented from the main window (not the popover's) and b.) needs a slightly hacky solution to prevent the popover from being closed (as AppKit doesn't really like it when you present modals from popovers nor present a modal when there's a popover being displayed).
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM