-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to targeted Swift Concurrency checking #937
Migrate to targeted Swift Concurrency checking #937
Conversation
let errorDescription: String | ||
let debugDescription: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These still conform to the error protocols that require them, so this shouldn't affect the behaviour of the app when receiving an exception. This change was made as NSException
doesn't conform to Sendable
but Swift.Error
does, so I've extracted out only the values of the exception that we use.
@@ -17,7 +17,7 @@ | |||
// | |||
|
|||
import Cocoa | |||
import Lottie | |||
@preconcurrency import Lottie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go away once we upgrade our Lottie version, but the latest version of Lottie doesn't work perfectly with our animations. I plan to request permission to pull our animation files out into a sample app and send it to the Lottie maintainers during my next maintenance days, as we're blocked from upgrading until they work again.
@MainActor func dataRecords(ofTypes dataTypes: Set<String>) async -> [WKWebsiteDataRecord] | ||
@MainActor func removeData(ofTypes dataTypes: Set<String>, modifiedSince date: Date) async | ||
@MainActor func removeData(ofTypes dataTypes: Set<String>, for records: [WKWebsiteDataRecord]) async |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really change any behaviour since this protocol wraps a type that needs to be on the main thread anyway, but the compiler isn't yet smart enough to know that so this just makes it happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 This is great! 🥇
* develop: (61 commits) Version Bump to 0.31.7 Update embedded files Update BSK with autofill 6.1.2 (#942) Migrate to targeted Swift Concurrency checking (#937) Add bundler configuration to limit Gemfile.lock noise (#939) update openssl depedency (#918) Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938) Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933) Sparkle 2 (#934) Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932) Add Danger (#928) Update BSK with autofill 6.1.1 (#920) Set version to 0.31.6 Fix GCC_OPTIMIZATION_LEVEL for Release and Review builds (#931) Disable testability for Release and Review builds (#929) update version update embedded files Remove the QuackDev reference. (#926) Bump find-in-page version (#889) Use ‘Settings’ in place of ‘Preferences’ on macOS Ventura (#925) ...
# By Dominik Kapusta (4) and others # Via GitHub * develop: Blockable JS Alerts inside tabs (#904) Fix add bookmark / folder modal in fullscreen (#930) Add Mac App Store target (#927) Pull request review checklist added to the pull request template (#935) Version Bump to 0.31.7 Update embedded files Update BSK with autofill 6.1.2 (#942) Migrate to targeted Swift Concurrency checking (#937) Add bundler configuration to limit Gemfile.lock noise (#939) update openssl depedency (#918) Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938) Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933) Sparkle 2 (#934) Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Task/Issue URL: https://app.asana.com/0/1199230911884351/1203759366656777/f
Tech Design URL:
CC: @mallexxx
Description:
This PR sets the macOS browser to use
Targeted
Swift Concurrency checks, and resolves warnings that came up when making that change.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM