Avoid using quackdev in DEBUG mode #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Jan 23, 2023
* develop: (61 commits) Version Bump to 0.31.7 Update embedded files Update BSK with autofill 6.1.2 (#942) Migrate to targeted Swift Concurrency checking (#937) Add bundler configuration to limit Gemfile.lock noise (#939) update openssl depedency (#918) Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938) Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933) Sparkle 2 (#934) Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932) Add Danger (#928) Update BSK with autofill 6.1.1 (#920) Set version to 0.31.6 Fix GCC_OPTIMIZATION_LEVEL for Release and Review builds (#931) Disable testability for Release and Review builds (#929) update version update embedded files Remove the QuackDev reference. (#926) Bump find-in-page version (#889) Use ‘Settings’ in place of ‘Preferences’ on macOS Ventura (#925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1203695370650863/f
Tech Design URL:
CC:
Description:
This PR removes the
quackdevemail URL that was being used in DEBUG mode. It no longer makes sense to use this as we're using our production accounts day to day, andquackdevshould only be used in the case where we have WIP changes deployed to the dev server.The other issue is that BSK wasn't using
quackdev, so the auth token wouldn't work when refreshing aliases.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM