Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testability for Release and Review builds #929

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Jan 13, 2023

Task/Issue URL: https://app.asana.com/0/1177771139624306/1203716819612150/f
CC: @brindy

Description:
Fix a misconfiguration in the project-level settings.

Steps to test this PR:

  1. Create a review and release builds (either with GHA or locally)
  2. Verify that they’re ca. 50MB and not 110MB.

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
  • Make sure configuration is changed only in xcconfig files, not in the Xcode project file directly

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit 58018db into develop Jan 13, 2023
@ayoy ayoy deleted the dominik/fix-testability-flag branch January 13, 2023 16:04
samsymons added a commit that referenced this pull request Jan 23, 2023
* develop: (61 commits)
  Version Bump to 0.31.7
  Update embedded files
  Update BSK with autofill 6.1.2 (#942)
  Migrate to targeted Swift Concurrency checking (#937)
  Add bundler configuration to limit Gemfile.lock noise (#939)
  update openssl depedency (#918)
  Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938)
  Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933)
  Sparkle 2 (#934)
  Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932)
  Add Danger (#928)
  Update BSK with autofill 6.1.1 (#920)
  Set version to 0.31.6
  Fix GCC_OPTIMIZATION_LEVEL for Release and Review builds (#931)
  Disable testability for Release and Review builds (#929)
  update version
  update embedded files
  Remove the QuackDev reference. (#926)
  Bump find-in-page version (#889)
  Use ‘Settings’ in place of ‘Preferences’ on macOS Ventura (#925)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants