Add Danger #928
Merged
Add Danger #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Jan 16, 2023
samsymons
added a commit
that referenced
this pull request
Jan 23, 2023
* develop: (61 commits) Version Bump to 0.31.7 Update embedded files Update BSK with autofill 6.1.2 (#942) Migrate to targeted Swift Concurrency checking (#937) Add bundler configuration to limit Gemfile.lock noise (#939) update openssl depedency (#918) Remove tab content when showing TabContent.none (such as for new tabs opened from navigation links) (#938) Update GRDB to 2.0.0 (upstream 6.6.0, SQLCipher 4.5.3) (#933) Sparkle 2 (#934) Bump Submodules/privacy-reference-tests from `de75d51` to `4fdbbb6` (#932) Add Danger (#928) Update BSK with autofill 6.1.1 (#920) Set version to 0.31.6 Fix GCC_OPTIMIZATION_LEVEL for Release and Review builds (#931) Disable testability for Release and Review builds (#929) update version update embedded files Remove the QuackDev reference. (#926) Bump find-in-page version (#889) Use ‘Settings’ in place of ‘Preferences’ on macOS Ventura (#925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200194497630846/1202817521327339/f
Tech Design URL: -
CC: @samsymons
Description:
This PR adds Danger with two simple rules (same of iOS as we are using a shared rules repository):
Warn if PR diffs contain more than 500 lines.
Warn if link to internal task is missing.
Steps to test this PR:
Make sure the Danger GH action completes successfully. Since the rules have been already tested on iOS and there are tests for them in the settings repository, this should be enough.
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM