Malicious site protection edge cases #249
Merged
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
commented
Dec 17, 2024
security/badware/index.html
Outdated
|
|
||
| <h2>Utility</h2> | ||
| <ul> | ||
| <li><a href="./phishing-iframe-top-navigator.html">Phishing iFrame Top Navigator</a></li> |
There was a problem hiding this comment.
BTW, do we even have to link to it? I think it only confuses folks since it's not a test.
There was a problem hiding this comment.
We can remove this link actually, it's not useful on its own.
kdzwinel
commented
Dec 17, 2024
| <li><a href="./malware-download.html">Malware Download Test</a></li> | ||
| </ul> | ||
|
|
||
| <h2>Redirects</h2> |
There was a problem hiding this comment.
Not sure if it's a useful grouping, just wanted to make things more findable given we now have a ton of those pages. I'm happy to revert this change if it doesn't make sense
There was a problem hiding this comment.
No this makes perfect sense. Thanks Konrad!
not-a-rootkit
approved these changes
Dec 17, 2024
| <li><a href="./malware-download.html">Malware Download Test</a></li> | ||
| </ul> | ||
|
|
||
| <h2>Redirects</h2> |
There was a problem hiding this comment.
No this makes perfect sense. Thanks Konrad!
security/badware/index.html
Outdated
|
|
||
| <h2>Utility</h2> | ||
| <ul> | ||
| <li><a href="./phishing-iframe-top-navigator.html">Phishing iFrame Top Navigator</a></li> |
There was a problem hiding this comment.
We can remove this link actually, it's not useful on its own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bundled couple of small changes: