Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malicious site protection edge cases #249

Merged
merged 4 commits into from
Dec 18, 2024
+37 −9
Merged

Malicious site protection edge cases #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cf4a89
Use current feature name (malicious site protection) on the index page
kdzwinel Dec 17, 2024
2d6a2d3
Reorganize malicious site protection test pages index and add edge ca…
kdzwinel Dec 17, 2024
192f5ed
Fix link to broken/excluded site
kdzwinel Dec 17, 2024
e2c2555
drop the utility page
kdzwinel Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ <h2>Security</h2>
<li><a href="./security/csp-report/index.html">Leak of extension IDs via CSP</a></li>
<li><a href="./security/js-leaks.html">Detect changes to JS objects in global scope</a></li>
<li><a href="./security/popups/popup-launcher.html">Popup noopener/noreferrer tests</a></li>
<li><a href="./security/badware/">Phishing Detection Pages</a></li>
<li><a href="./security/badware/">Malicious Site Protection Test Pages</a></li>
</ul>

<h2>Privacy Protections Tests</h2>
Expand Down
26 changes: 18 additions & 8 deletions security/badware/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,30 @@

<head>
not-a-rootkit marked this conversation as resolved.
Show resolved Hide resolved
<meta charset="UTF-8">
<title>Test Pages - Phishing Detection</title>
<title>Test Pages - Malicious Site Protection</title>
</head>

<body>
<h1>Phishing Detection Test Pages</h1>
<h1>Malicious Site Protection Test Pages</h1>
<a href="/">[Home]</a>
<ul>
<li><a href="./phishing.html">Standard Phishing Test</a></li>
<li><a href="./malware.html">Standard Malware Test</a></li>
<li><a href="./malware-download.html">Malware Download Test</a></li>
<li><a href="./phishing-iframe-loader.html">Phishing iFrame Loader</a></li>
<li><a href="./phishing-js-redirector-helper.html">Phishing JS Redirector (Direct)</a></li>
<li><a href="./phishing-js-redirector.html">Phishing JS Redirector (Indirect)</a></li>
<li><a href="./phishing-legit-iframe-loader.html">Phishing Legit iFrame Loader</a></li>
<li><a href="./phishing-meta-redirect-clean.html">Phishing Redirect via Meta Refresh (Not Flagged in Dataset)</a></li>
<li><a href="./phishing-meta-redirect.html">Phishing Redirect via Meta Refresh (Flagged in Dataset)</a></li>
<li><a href="./phishing-popups.html">Phishing Open via Popups</a></li>
<li><a href="./phishing-url-tampering.html">Phishing Opening with URL Tampering</a></li>
<li><a href="./phishing-form-submission.html">Phishing Form Submission</a></li>
<li><a href="./phishing-iframe-top-navigator.html">Phishing iFrame Top Navigator</a></li>
<li><a href="./phishing-service-worker.html">Phishing Service Worker</a></li>
<li><a href="./malware-download.html">Malware Download Test</a></li>
</ul>

<h2>Redirects</h2>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's a useful grouping, just wanted to make things more findable given we now have a ton of those pages. I'm happy to revert this change if it doesn't make sense

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this makes perfect sense. Thanks Konrad!

<ul>
<li><a href="./phishing-meta-redirect-clean.html">Phishing Redirect via Meta Refresh (Not Flagged in Dataset)</a></li>
<li><a href="./phishing-meta-redirect.html">Phishing Redirect via Meta Refresh (Flagged in Dataset)</a></li>
<li><a href="./phishing-js-redirector-helper.html">Phishing JS Redirector (Direct)</a></li>
<li><a href="./phishing-js-redirector.html">Phishing JS Redirector (Indirect)</a></li>
<li><a href="./phishing-iframe-top-navigator-parent.html">Phishing iFrame Top Navigator Parent</a></li>
<li><a href="/security/badware/phishing-redirect/">HTTP 301 Redirect to Main Phishing Test Page</a></li>
<li><a href="/security/badware/phishing-redirect/302">HTTP 302 Redirect to Main Phishing Test Page</a></li>
Expand All @@ -34,6 +37,13 @@ <h1>Phishing Detection Test Pages</h1>
<li><a href="/security/badware/phishing-redirect/meta">HTTP Redirect to Clean Meta Refresh Redirector</a></li>
<li><a href="/security/badware/phishing-redirect/meta2">HTTP Redirect to Flagged Meta Refresh Redirector</a></li>
</ul>

<h2>Edge Cases</h2>
<ul>
<li><a href="http://malware.privacy-test-pages.site/security/badware/malware.html">Page flagged by both DNS protection and in-browser protection</a> (⚠️ different domain)</li>
<li><a href="https://broken.third-party.site/security/badware/malware.html">Page where malicious site protection is disabled via remote config exception</a> (⚠️ different domain)</li>
<li><a href="./local-check.html">Page flagged in the local data (doesn't require API request)</a></li>
</ul>
</body>

</html>
18 changes: 18 additions & 0 deletions security/badware/local-check.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html>

<head>
<meta charset="utf-8">
<title>Local-check malware page</title>
</head>

<body>
<p><a href="/security/badware/">[Back]</a></p>

<h1>Local check malware page</h1>

<p>This is an example malware page that DuckDuckGo clients intend to block. If you arrive here by mistake; there's
nothing to worry about, we just use this page to test if our client blocking is working.</p>

</body>
</html>
Loading