Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Prod Release into Master #1661

Open
wants to merge 102 commits into
base: master
Choose a base branch
from
Open

Merge Prod Release into Master #1661

wants to merge 102 commits into from

Conversation

cvs-ops
Copy link
Contributor

@cvs-ops cvs-ops commented Dec 4, 2024

Source: Release release/v3.37.0

pbardy2000 and others added 30 commits May 2, 2024 09:20
@pbardy2000
feat(cb2-11930): ensure certificate number is sent to backend if it e…
66cbf38 
…xists on MVSA IVA tests (#1481)

* feat(cb2-11930): ensure certificate number is sent to backend if its exists on MVSA IVA tests

* feat(cb2-11930): fix linting issue
@tomevs88
feat(cb2-12056): test codes moved (#1486)
59655f3 
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
@BrandonT95 @tomcrawleyy
@tomevs88 @pbardy2000
feat(RELEASE-123): merge holding branch back into develop (#1490)
df1c0ae 
* feat(cb2-10241): update adr notes to use custom component (#1446)

* feat/CB2-11250 - Edit button on additional examiner notes takes you to blank page (#1447)

* feat(cb2-10241): update adr notes to use custom component

* feat(cb2-11250): format table

* feat(cb2-11250): set up router link

* feat(cb2-11250): blank page link working

* feat(cb2-11250): revert unnecessary changes

* feat(cb2-11250): amend routing function

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): update link design

* feat(cb2-11250): fix button link styling

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>

* feat(CB2-9916): Add warning to cherished transfer (#1451)

* feat(cb2-9916): added cherised transfer warning message for psv and hgv

* feat(cb2-9916): fix linting

* feat(cb2-10032): add pagination to adr examiner notes (#1450)

* feat(cb2-10032): add pagination to adr examiner notes

* feat(cb2-10032): add pagination to notes amend view

* feat(cb2-11103): createdAtDate for adr examiner notes now save as full iso date string (#1452)

* feat(cb2-11103): ability to submit and show date and time for adr notes creation

* feat(cb2-11103): fix unit test

* feat(cb2-11103): fix other unit test

* feat/CB2-10033 - Additional Examiner Note (#1448)

* feat(cb2-10241): update adr notes to use custom component

* feat(cb2-11250): format table

* feat(cb2-11250): set up router link

* feat(cb2-11250): blank page link working

* feat(cb2-11250): revert unnecessary changes

* feat(cb2-11250): amend routing function

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): update link design

* feat(cb2-11250): fix button link styling

* feat(cb2-10033): basic setup and grabbed selected note from record

* feat(cb2-10033): stash for mobbing

* feat(cb2-10033): hook form up to display note which is to be edited

* feat(cb2-10033): set up model binding to component

* feat(cb2-10033): use correct directive and basic form validation

* feat(cb2-10033): amend routing title for notifiable alteration

* feat(cb2-10033): remove validation as requirements confirmed not needed

* feat(cb2-10033): implement state management solution

* feat(cb2-10033): fix display for summary screen

* feat(cb2-10033): refactor state and data handling approach

* feat(cb2-10033): reducer tests

* feat(cb2-10033): basic unit testing draft

* feat(cb2-10033): unit testing

* feat(cb2-10033): linting fix

* feat(cb2-10033): fix review screen

* feat(cb2-10033): git stash for mobbing

* feat(cb2-10033): add logic to hide collapse function and fix missing acs

* feat(cb2-10033): move title from component to templates

* feat(cb2-10033): acordion issues solved

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>

* feat(cb2-10033): upped char count to 151 (#1453)

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>

* feat(cb2-10033): upped char count to 150

* feat(cb2-10033): upped char count to 150

* feat(cb2-10033): upped char count to 15 again

* feat(cb2-10033): css removed

* fix(cb2-11103): re-add missing timestamp from adr notes view (#1460)

* feat(cb2-10286): add hint text to 3 month extension (#1462)

* feat(cb2-10973): feature flags changed to show IVA flow in all envs (#1465)

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>

* feat(cb2-10125): make adr guidance notes a checkbox group (#1466)

* feat(cb2-11546): make 'make' required for HGVs and TRLs which carry dangerous goods (#1461)

* fix(cb2-11546): make vehicle make required when carrying dangerous goods

* feat(cb2-11546): only make applicable for HGVs and LGVs

* feat(cb2-10286): add new certificate required field (#1463)

* feat(cb2-10286): add new certificate required field

* feat(cb2-9747): default checkbox to false so it will correctly display no text in read mode

* feat/CB2-10740 - Mark if a vehicle is used for international journeys on VTM (#1467)

* feat(cb2-10740): hook up template and values correctly to type definition

* feat(cb2-10740): lint fix

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* fix(cb2-9747): fix failing unit test (#1468)

* fix(cb2-9747): create mocked date to fix failing unit test (#1469)

* feat(cb2-11185): ensure correct text-wrapping. (#1473)

* fix(cb2-11185): break text to avoid long strings causing the page to overflow horizontally

* fix(cb2-11185): break long strings to overflow, but not mid-word unless necessary

* fix(cb2-11185): fix linting

* fix(cb2-10419): change casing in select defect (#1474)

* fix(cb2-11302): correct spelling of accessor to assessor (#1475)

* fix(cb2-10562): prevent submitting a psv with one axle (#1480)

* fix(cb2-11069): reset error message when new data is provided (#1479)

* fix(cb2-11068): allow unset as form node width so it never hides option text (#1478)

* fix(CB2-11243): prevent SR field in tyres component being cut-off on large screens (#1477)

* fix(cb2-11068): allow unset as form node width so it never hides option text

* fix(cb2-11243): set width to unset to select autoscales to text

* fix(CB2-11453): prevent download .zip file in seperate window (as this may be blocked) (#1476)

* fix(cb2-11453): do not download link via external tab

* fix(cb2-11453): fix unit test

* feat(cb2-11930): ensure certificate number is sent to backend if it exists on MVSA IVA tests (#1482)

* feat(cb2-11930): ensure certificate number is sent to backend if its exists on MVSA IVA tests

* feat(cb2-11930): fix linting issue

* fix(cb2-11908): remove duplicate label from additional examiner notes history (#1483)

* feat(cb2-12056): test codes moved (#1487)

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>

---------

Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>
@pbardy2000 @BrandonT95
@tomcrawleyy @tomevs88
fix(cb2-11908): Change labels of examiner notes (#1491)
b15764f 
* feat(cb2-10241): update adr notes to use custom component (#1446)

* feat/CB2-11250 - Edit button on additional examiner notes takes you to blank page (#1447)

* feat(cb2-10241): update adr notes to use custom component

* feat(cb2-11250): format table

* feat(cb2-11250): set up router link

* feat(cb2-11250): blank page link working

* feat(cb2-11250): revert unnecessary changes

* feat(cb2-11250): amend routing function

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): update link design

* feat(cb2-11250): fix button link styling

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>

* feat(CB2-9916): Add warning to cherished transfer (#1451)

* feat(cb2-9916): added cherised transfer warning message for psv and hgv

* feat(cb2-9916): fix linting

* feat(cb2-10032): add pagination to adr examiner notes (#1450)

* feat(cb2-10032): add pagination to adr examiner notes

* feat(cb2-10032): add pagination to notes amend view

* feat(cb2-11103): createdAtDate for adr examiner notes now save as full iso date string (#1452)

* feat(cb2-11103): ability to submit and show date and time for adr notes creation

* feat(cb2-11103): fix unit test

* feat(cb2-11103): fix other unit test

* feat/CB2-10033 - Additional Examiner Note (#1448)

* feat(cb2-10241): update adr notes to use custom component

* feat(cb2-11250): format table

* feat(cb2-11250): set up router link

* feat(cb2-11250): blank page link working

* feat(cb2-11250): revert unnecessary changes

* feat(cb2-11250): amend routing function

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): fix linting and add unit test

* feat(cb2-11250): update link design

* feat(cb2-11250): fix button link styling

* feat(cb2-10033): basic setup and grabbed selected note from record

* feat(cb2-10033): stash for mobbing

* feat(cb2-10033): hook form up to display note which is to be edited

* feat(cb2-10033): set up model binding to component

* feat(cb2-10033): use correct directive and basic form validation

* feat(cb2-10033): amend routing title for notifiable alteration

* feat(cb2-10033): remove validation as requirements confirmed not needed

* feat(cb2-10033): implement state management solution

* feat(cb2-10033): fix display for summary screen

* feat(cb2-10033): refactor state and data handling approach

* feat(cb2-10033): reducer tests

* feat(cb2-10033): basic unit testing draft

* feat(cb2-10033): unit testing

* feat(cb2-10033): linting fix

* feat(cb2-10033): fix review screen

* feat(cb2-10033): git stash for mobbing

* feat(cb2-10033): add logic to hide collapse function and fix missing acs

* feat(cb2-10033): move title from component to templates

* feat(cb2-10033): acordion issues solved

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>

* feat(cb2-10033): upped char count to 151 (#1453)

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>

* feat(cb2-10033): upped char count to 150

* feat(cb2-10033): upped char count to 150

* feat(cb2-10033): upped char count to 15 again

* feat(cb2-10033): css removed

* fix(cb2-11103): re-add missing timestamp from adr notes view (#1460)

* feat(cb2-10286): add hint text to 3 month extension (#1462)

* feat(cb2-10973): feature flags changed to show IVA flow in all envs (#1465)

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>

* feat(cb2-10125): make adr guidance notes a checkbox group (#1466)

* feat(cb2-11546): make 'make' required for HGVs and TRLs which carry dangerous goods (#1461)

* fix(cb2-11546): make vehicle make required when carrying dangerous goods

* feat(cb2-11546): only make applicable for HGVs and LGVs

* feat(cb2-10286): add new certificate required field (#1463)

* feat(cb2-10286): add new certificate required field

* feat(cb2-9747): default checkbox to false so it will correctly display no text in read mode

* feat/CB2-10740 - Mark if a vehicle is used for international journeys on VTM (#1467)

* feat(cb2-10740): hook up template and values correctly to type definition

* feat(cb2-10740): lint fix

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* fix(cb2-9747): fix failing unit test (#1468)

* fix(cb2-9747): create mocked date to fix failing unit test (#1469)

* feat(cb2-11185): ensure correct text-wrapping. (#1473)

* fix(cb2-11185): break text to avoid long strings causing the page to overflow horizontally

* fix(cb2-11185): break long strings to overflow, but not mid-word unless necessary

* fix(cb2-11185): fix linting

* fix(cb2-10419): change casing in select defect (#1474)

* fix(cb2-11302): correct spelling of accessor to assessor (#1475)

* fix(cb2-10562): prevent submitting a psv with one axle (#1480)

* fix(cb2-11069): reset error message when new data is provided (#1479)

* fix(cb2-11068): allow unset as form node width so it never hides option text (#1478)

* fix(CB2-11243): prevent SR field in tyres component being cut-off on large screens (#1477)

* fix(cb2-11068): allow unset as form node width so it never hides option text

* fix(cb2-11243): set width to unset to select autoscales to text

* fix(CB2-11453): prevent download .zip file in seperate window (as this may be blocked) (#1476)

* fix(cb2-11453): do not download link via external tab

* fix(cb2-11453): fix unit test

* fix(cb2-11908): remove duplicate label from additional examiner notes history

* fix(cb2-11908): Change labels of examiner notes

* fix(cb2-11908): fix unit tests

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>
Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
@pbardy2000
fix(cb2-12009): default psv body model to null if its an empty string (…
36963fb 
…#1493)

* fix(cb2-12009): default psv body model to null if its an empty string

* fix(cb2-12009): add snyk ignore

* fix(cb2-12009): correct snyk ignore indentation

* fix(cb2-12009): add package number to snyk ignore
@tomcrawleyy
feat(cb2-12304): add id (#1494)
521eb01
@pbardy2000 @JoshCarter-ops
fix(cb2-12599): ensure additional examiner notes appear in the correc… (
449c449 
#1497)

* fix(cb2-12599): ensure additional examiner notes appear in the correct order

* feat(cb2-12599) adding temp fixup for the gha action

* Update pr-checks.yml

* fix(cb2-12599): updated references in pr checks gha job

* fix(cb2-12599) removed node16 version from scanner

---------

Co-authored-by: Josh Carter <35105612+JoshCarter-ops@users.noreply.github.com>
@tomcrawleyy
feat/cb2 12722-2 - Use new google tag manager npm plugin (#1502)
b7edfdc 
* feat(dev-no-analytics): remove analytics implementation

* feat(cb2-12722): add gtm plugin

* feat(cb2-12722): add new gtm plugin and fix tests
@pbardy2000
feat(cb2-12600): add form control to specialist contingency test (#1500)
501f10e 
* feat(cb2-12600): add form control to specialist contingency test group 1 and 5

* feat(cb2-12600): add hint text

* feat(cb2-12600): adjust error messages so they match ACs

* feat(cb2-12600): fix linting

* feat(cb2-12600): enable viewing reapplication date on view history and amend

* feat(cb2-12600): fix linting
@pbardy2000
Feat/cb2 12600 (#1503)
96736f5 
* feat(cb2-12600): add form control to specialist contingency test group 1 and 5

* feat(cb2-12600): add hint text

* feat(cb2-12600): adjust error messages so they match ACs

* feat(cb2-12600): fix linting

* feat(cb2-12600): enable viewing reapplication date on view history and amend

* feat(cb2-12600): fix linting

* feat(cb2-12600): remove reapplication date from group 5 templates

* feat(cb2-12600): remove reapplication date from group 5

* feat(cb2-12600): fix the linting
@pbardy2000
Feat/cb2 12600 (#1504)
e144fba 
* feat(cb2-12600): add form control to specialist contingency test group 1 and 5

* feat(cb2-12600): add hint text

* feat(cb2-12600): adjust error messages so they match ACs

* feat(cb2-12600): fix linting

* feat(cb2-12600): enable viewing reapplication date on view history and amend

* feat(cb2-12600): fix linting

* feat(cb2-12600): remove reapplication date from group 5 templates

* feat(cb2-12600): remove reapplication date from group 5

* feat(cb2-12600): fix the linting

* feat(cb2-12600): hide reapplication date when amending passed specialist test

* feat(cb2-12600): fix linting
@matthew2564
chore(dependency-1): remove cypress config and dependencies (#1507)
e339cda
@matthew2564
chore(husky-1): update command to remove deprecation warning (#1509)
b57b56a
@BrandonT95
fix(cb2-12972): allow users to submit cancelled iva tests (#1517)
688c526
@pbardy2000
fix(cb2-12006): prevent error message duplication (#1492)
340bdd9 
* fix(cb2-12006): prevent error message duplication

* fix(cb2-12006): fix unit test
@matthew2564
chore(storybook-1): removal of storybook dependencies and commands (#…
89691a4 
…1511)
@matthew2564
chore(cypress-1): further removal of cypress and any config related (#…
1b55ad4 
…1510)
@JoshCarter-ops
Update deploy-prod.yml (#1520)
c54e0fa
@pbardy2000
feat(cb2-13176): VTM - Add guidance for handling documents issued cen…
e5d5615 
…trally (#1519)

* feat(cb2-13164): add issue documents centrally

* feat(cb2-13164): issue documents centrally for all relevant templates

* feat(cb2-13164): fix linting

* feat(cb2-13164): change name from issueDocumentsCentrally to issueRequired to match BE

* feat(cb2-13164): fix linting again

* feat(cb2-13164): hide for group 1

* feat(cb2-13164): fix linting again again

* feat(cb2-13164): set issueRequired to false for fail/abandon

* feat(cb2-13176): conditionally show hint text on ADR tests only

* feat(cb2-13176): fix linting

* feat(cb2-13176): remove issue docs centrally from groups 2 3 4 and add to 15 and 16

* feat(cb2-13176): remove issue required from  group 3

* feat(cb2-13176): remove validation for certificate number on groups 3 and 4

* feat(cb2-13176): fix linting

* feat(cb2-13176): use nested shape

* feat(cb2-13176): fix linting

* feat(cb2-13176): ensure reasons for issue is always an array of strings
@pbardy2000 @tomevs88
feat(cb2-13299): VTM - Pass and issue Documents Centrally for a Notif…
aafbbb2 
…iable Alteration test (#1521)

* feat(cb2-13164): add issue documents centrally

* feat(cb2-13164): issue documents centrally for all relevant templates

* feat(cb2-13164): fix linting

* feat(cb2-13164): change name from issueDocumentsCentrally to issueRequired to match BE

* feat(cb2-13164): fix linting again

* feat(cb2-13164): hide for group 1

* feat(cb2-13164): fix linting again again

* feat(cb2-13164): set issueRequired to false for fail/abandon

* feat(cb2-13176): conditionally show hint text on ADR tests only

* feat(cb2-13176): fix linting

* feat(cb2-13176): remove issue docs centrally from groups 2 3 4 and add to 15 and 16

* feat(cb2-13176): remove issue required from  group 3

* feat(cb2-13176): remove validation for certificate number on groups 3 and 4

* feat(cb2-13176): fix linting

* feat(cb2-13176): use nested shape

* feat(cb2-13176): fix linting

* feat(cb2-13176): ensure reasons for issue is always an array of strings

* feat(cb2-13299): enable issue documents centrally for free or paid notifiable alteration test types

---------

Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
@tomcrawleyy
Revert "feat(cb2-13299): VTM - Pass and issue Documents Centrally for…
70c3984 
… a Notif…" (#1523)

This reverts commit aafbbb2.
@tomcrawleyy
Revert "feat(cb2-13176): VTM - Add guidance for handling documents is…
6bfbc2d 
…sued cen…" (#1524)

This reverts commit e5d5615.
@BrandonT95
chore(version-bump): bump version (#1526)
466b955
@BrandonT95
chore(version-bump): bump package lock (#1527)
a3567d5 
* chore(version-bump): bump version

* chore(version-bump): bump version
@BrandonT95 @tomevs88
Revert "Revert "feat(cb2-13176): VTM - Add guidance for handling docu…
8d5d29f 
…ments is…" (#1525)

This reverts commit 6bfbc2d.

Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
@BrandonT95
Revert "Revert "feat(cb2-13299): VTM - Pass and issue Documents Centr…
fc17a4e 
…ally for…" (#1528)

This reverts commit 70c3984.
@tomevs88
feat(13396):lec removed (#1529)
2883f15 
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
@pbardy2000
feat(cb2-13176): only show hint text for pass/prs results (#1531)
e07514f
@pbardy2000
fix(cb2-13506): use correct notes section on amending ADR tests (#1533)
ab634e7 
* fix(cb2-13506): use correct notes section on amending ADR tests

* fix(cb2-13506): fix linting
@pbardy2000 @BrandonT95
feat(cb2-13455): VTM - Pass and issue Documents Centrally (additional…
e78d142 
… test type ids) (#1530)

* feat(cb2-13455): add issue docs centrally for first test and first test prohibition clearance

* feat(cb2-13455): linting

* feat(cb2-13455): fix linting

* feat(cb2-13455): fix template

* feat(cb2-13455): show issue docs for prs

---------

Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>
pbardy2000 and others added 27 commits October 8, 2024 13:43
@pbardy2000
feat(cb2-12988): update favicon (#1607)
a8f68c9
@pbardy2000 @tomevs88
feat(cb2-11402): change display type (#1495)
37bddf4 
* feat(cb2-11402): change display type

* feat(cb2-11402): fix linting

* feat(cb2-11402): fix linting

---------

Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
@pbardy2000
Chore/update angular packages (#1608)
e57b3a6 
* chore(cb2-0000): update angular packages

* chore(cb2-0000): update angular core packages
@pbardy2000
feat(cb2-11336): allow apostrophes in email addresses (#1610)
ed0458c
@pbardy2000
feat(cb2-12179): only allow adr tests on adr vehicles carrying danger…
3d8a0d0 
…ous goods (#1618)
@BrandonT95
feat(cb2-13331): add smoke test k limit validation for decimals (#1620)
3541e59
@pbardy2000
fix(cb2-14415): allow proper clearing of ADR details (#1619)
9f9ffa7
@pbardy2000
fix(cb2-13831): retry on status of 0 (#1622)
cfa0937 
* fix(cb2-13831): retry on status of 0

* fix(cb2-13831): add unit test to mock unknown response situation
@pbardy2000
fix(cb2-14662): prevent non decimal characters (#1623)
b30c70e
@tomcrawleyy
feat(cb2-0000): resolve missing id for pack (#1624)
d5a2e9a
@pbardy2000
fix(cb2-14242): do not default value of battery list applicable (#1625)
5860fe4
@pbardy2000
chore(cb2-0000): upgrade packages (#1627)
78557b6
@tomcrawleyy @tomevs88
feature/CB2-11802 - Add body declaration type field to VTM ADR section (
bb3528e 
#1626)

* feat(cb2-11802): basic boilerplate

* feat(cb2-11802): basic validation changes

* feat(cb2-11802): update enums and their values

* feat(cb2-11802): stash

* feat(cb2-11802): small change to model

* feat(cb2-11802): added to payload

---------

Co-authored-by: Thomas Evans <36958694+tomevs88@users.noreply.github.com>
@matthew2564 @pbardy2000
chore: relax rules to not have to provide ticket number in scope (#1605)
68d0816 
Co-authored-by: Philip Bardy <146740183+pbardy2000@users.noreply.github.com>
@tomcrawleyy
feat(cb2-14943): remove validator which makes field required (#1628)
50bf320
@pbardy2000
fix(cb2-14944): show body declaration under specific conditions (#1629)
02fda73 
* fix(cb2-14944): show body declaration under specific conditions

* fix(cb2-14944): move variables to different scope
@pbardy2000
fix(CB2-14953) (#1630)
bbda541 
* fix(cb2-14953): do not save body declaration when its not applicable

* fix(cb2-14953): update comment
@pbardy2000
feat(cb2-9597): add manufacture month for TRLs (#1634)
b22690c
@pbardy2000
fix(cb2-12719): actually dispatch action (#1498)
9111461 
* fix(cb2-12719): actually dispatch action

* fix(cb2-12719): fix linting

* fix(cb2-12719): final lint fixes

* fix(cb2-12719): lint correctly
@tomevs88
feat(cb2-14690): version number (#1636)
ba382a8 
* feat(cb2-14690): version number

* feat(cb2-14690): version number comments addressed

* feat(cb2-14690): version number comments addresseds

* feat(cb2-14690): version number comments address

---------

Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
@pbardy2000
fix(cb2-13642): when prohibition issue is hidden in edit mode, hide i…
c274c93 
…t on the review screen (#1635)
@pbardy2000 @tomcrawleyy
feat(cb2-11403): remove DFS, add tag (#1631)
bbba66b 
Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
@pbardy2000
feat(cb2-9597): add month of manufacture to small trailers (#1637)
9c4bcee 
* feat(cb2-9597): add manufacture month for TRLs

* feat(cb2-9597): add month of manufacture to small trls
@matthew2564
feat(cb2-14315): ngrx based approach for internal logging system (#1616)
32d6872 
* feat(cb2-14315): ngrx based approach for internal logging system

* feat(cb2-14315): add test for automation flag not sending logs

* fix: standardise error log between vtx

* chore: remove cache from mito test
@pbardy2000
feat(cb2-15038): allow current year +1 for year of manufacture (#1639)
a87d2f2
@matthew2564
chore: bump app version 1.28 (#1649)
dbcab56
@pbardy2000 @tomcrawleyy @BrandonT95
Feat/cb2 14457 release 3.37.0 (#1654)
3104b44 
* chore(cb2-0000): basic form

* chore(cb2-0000): changes

* chore(cb2-0000): add view and summary mode

* chore(cb2-0000): add example directive

* chore(cb2-0000): add dates and directives

* chore(cb2-0000): adr section changes

* chore(cb2-0000): fix issues with global error service

* chore(cb2-0000): fix validation for ADR section

* chore(cb2-0000): fix tc3 validator

* chore(cb2-0000): general ADR section fixes

* chore(cb2-0000): allow editing fields on different pages

* chore(cb2-0000): replicate behaviour around explosives

* chore(cb2-0000): fix unit tests

* feat(cb2-14457): migrate styles and directives over

* feat(cb2-14457): attempt at using new styles and directive

* feat(cb2-14457): attempt at using new styles and directive

* feat(cb2-14457): add automation ids

* feat(cb2-14457): amend review screen

* feat(cb2-14457): convert inputs to gds format

* feat(cb2-14457): add body declaration

* feat(cb2-14457): add ids to input labels

* feat(cb2-14457): migrate last of inputs to gds

* feat(cb2-14457): more radios

* feat(cb2-14457): final radio

* feat(cb2-14457): make dates less verbose

* feat(cb2-14457): checkbox styling and small fixes

* feat(cb2-14457): checkbox styling

* feat(cb2-14457): directives rework

* feat(cb2-14457): selects refactored

* feat(cb2-14457): fix date errors

* feat(cb2-14457): text area refactor

* feat(cb2-14457): introduce styling for dates

* feat(cb2-14457): label cleanup

* feat(cb2-14457): fix date styling and unit tests

* Feat/cb2 14457 (#1642)

* chore(cb2-0000): basic form

* chore(cb2-0000): changes

* chore(cb2-0000): add view and summary mode

* chore(cb2-0000): add example directive

* chore(cb2-0000): add dates and directives

* chore(cb2-0000): adr section changes

* chore(cb2-0000): fix issues with global error service

* chore(cb2-0000): fix validation for ADR section

* chore(cb2-0000): fix tc3 validator

* chore(cb2-0000): general ADR section fixes

* chore(cb2-0000): allow editing fields on different pages

* chore(cb2-0000): replicate behaviour around explosives

* chore(cb2-0000): fix unit tests

* feat(cb2-14457): migrate styles and directives over

* feat(cb2-14457): attempt at using new styles and directive

* feat(cb2-14457): attempt at using new styles and directive

* feat(cb2-14457): add automation ids

* feat(cb2-14457): amend review screen

* feat(cb2-14457): convert inputs to gds format

* feat(cb2-14457): add body declaration

* feat(cb2-14457): add ids to input labels

* feat(cb2-14457): migrate last of inputs to gds

* feat(cb2-14457): more radios

* feat(cb2-15038): allow current year +1 for year of manufacture (#1639)

* feat(cb2-14457): final radio

* feat(cb2-14457): make dates less verbose

* feat(cb2-14457): checkbox styling and small fixes

* feat(cb2-14457): checkbox styling

* feat(cb2-14457): directives rework

* feat(cb2-14457): selects refactored

* feat(cb2-14457): fix date errors

* feat(cb2-14457): text area refactor

* feat(cb2-14457): introduce styling for dates

* feat(cb2-14457): label cleanup

* feat(cb2-14457): fix date styling and unit tests

---------

Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>

* feat(cb2-14457): don't override element id

* feat(cb2-14457): remove id and name

* feat(cb2-14457): remove id and name (#1643)

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* feat(cb2-14457): add checkbox to ids

* Feat/cb2 14457 (#1644)

* feat(cb2-14457): remove id and name

* feat(cb2-14457): add checkbox to ids

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* feat(cb2-14457): character count id fix

* Feat/cb2 14457 - text area id's (#1645)

* feat(cb2-14457): remove id and name

* feat(cb2-14457): add checkbox to ids

* feat(cb2-14457): character count id fix

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* feat(cb2-14457): character count corrections

* feat(cb2-14457): add additional details

* feat(cb2-14457): resolve validator message mismatch

* feat/cb2-14457 (#1646)

* feat(cb2-14457): remove id and name

* feat(cb2-14457): add checkbox to ids

* feat(cb2-14457): character count id fix

* feat(cb2-14457): character count corrections

* feat(cb2-14457): add additional details

* feat(cb2-14457): resolve validator message mismatch

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* feat(cb2-14457): amend additional examiner notes validator

* Feat/cb2 14457 (#1647)

* feat(cb2-14457): remove id and name

* feat(cb2-14457): add checkbox to ids

* feat(cb2-14457): character count id fix

* feat(cb2-14457): character count corrections

* feat(cb2-14457): add additional details

* feat(cb2-14457): resolve validator message mismatch

* feat(cb2-14457): amend additional examiner notes validator

---------

Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com>

* feat(cb2-14457): more additional examiner notes amendments

* feat(cb2-14457): add ids to inline error messages

* feat(cb2-14457): change to using element id, use correct id in label fors

* feat(cb2-14457): fix labels

* feat(cb2-14457): fix battery list applicable validation

* feat(cb2-14457): test

* feat(cb2-14457): fix error messages for automation pack

* feat(cb2-14457): fix ADR specific issues

* feat(cb2-14457): correct max length validation

* feat(cb2-14457): correct more messages

* feat(cb2-14457): fix batch plating

* feat(cb2-14457): change wording

* feat(cb2-14457): fix spelling

* feat(cb2-14457): change date validation

* feat(cb2-14457): year must be four digits

* feat(cb2-14457): fix discrepancies with develop

* feat(cb2-14457): add missing details

* feat(cb2-14722): fix displaying of additional defects on test history (#1652)

* feat(cb2-14457): only show brake endurance with issue section

* feat(cb2-14457): show brake endurance with issuer

* feat(cb2-14457): improvments

* feat(cb2-14457): improvments again

* feat(cb2-14457): change conditions for displaying ADR details message

* feat(cb2-14457): turn flags on

* Revert "Merge branch 'develop' into feat/cb2-14457"

This reverts commit de4f62e, reversing
changes made to 70000bb.

* feat(cb2-14457): update vtm version number

---------

Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com>
Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2024
View reviewed changes
src/app/store/test-records/test-records.effects.ts
const field = error.match(/"([^"]+)"/);
validationsErrors.push({
error,
anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High test

This replaces only the first occurrence of '"'.

Copilot Autofix AI 7 days ago

To fix the problem, we need to ensure that all occurrences of the double-quote character in the field[1] string are replaced. The best way to achieve this is by using a regular expression with the global flag (g). This will ensure that all double-quote characters are replaced, not just the first one.

We will replace the replace method call with a regular expression that includes the global flag. This change will be made on line 126 of the file src/app/store/test-records/test-records.effects.ts.

Suggested changeset 1
src/app/store/test-records/test-records.effects.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/app/store/test-records/test-records.effects.ts b/src/app/store/test-records/test-records.effects.ts
--- a/src/app/store/test-records/test-records.effects.ts
+++ b/src/app/store/test-records/test-records.effects.ts
@@ -125,3 +125,3 @@
 											error,
-											anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',
+											anchorLink: field && field.length > 1 ? field[1].replace(/"/g, '') : '',
 										});
EOF
@@ -125,3 +125,3 @@
error,
anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',
anchorLink: field && field.length > 1 ? field[1].replace(/"/g, '') : '',
});
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
src/app/store/test-records/test-records.effects.ts
const field = error.match(/"([^"]+)"/);
validationsErrors.push({
error,
anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High test

This replaces only the first occurrence of '"'.

Copilot Autofix AI 7 days ago

To fix the problem, we need to ensure that all occurrences of the double-quote character are replaced, not just the first one. This can be achieved by using a regular expression with the global flag (g). Specifically, we should replace the replace method call with one that uses a regular expression to replace all double-quote characters.

Suggested changeset 1
src/app/store/test-records/test-records.effects.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/app/store/test-records/test-records.effects.ts b/src/app/store/test-records/test-records.effects.ts
--- a/src/app/store/test-records/test-records.effects.ts
+++ b/src/app/store/test-records/test-records.effects.ts
@@ -182,3 +182,3 @@
 										error,
-										anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',
+										anchorLink: field && field.length > 1 ? field[1].replace(/"/g, '') : '',
 									});
EOF
@@ -182,3 +182,3 @@
error,
anchorLink: field && field.length > 1 ? field[1].replace('"', '') : '',
anchorLink: field && field.length > 1 ? field[1].replace(/"/g, '') : '',
});
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@github-actions github-actions bot added the merge conflict PR needs rebasing label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict PR needs rebasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cvs-ops @dwalbjss @pbardy2000 @tomevs88 @BrandonT95 @tomcrawleyy @matthew2564 @JoshCarter-ops