-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIXUP page #625
base: main
Are you sure you want to change the base?
Add MIXUP page #625
Conversation
Deploying dwhdelft-nl with Cloudflare Pages
|
Deploying outsite-nl with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two random initial comments, will take a more in-depth look later :)
but at first sight: looks cool! Good reuse of existing things!
dwhdelft.nl/pages/mixup.vue
Outdated
</section> | ||
|
||
<section class="mixup-colors"> | ||
<div class="bg-[url('~/assets/images/photos/mixup/barvisual.jpg')] bg-cover bg-center py-10"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line where the image is used as a background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A slightly more in-depth review ;)
Still looks cool overall, a lot of details in my comments. Some more important than other ;)
Let me know if you have any questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These SVGs look like pngs converted to SVG. Are the original vector files available to create an SVG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't have these. I already had to pull these out of a random MIXUP design guide on Drive. I reached out to see if MIXUP has it.
Fix linked events async data issues
No description provided.