Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIXUP page #625

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Add MIXUP page #625

wants to merge 38 commits into from

Conversation

thomcsmits
Copy link
Collaborator

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95c6a66
Status: ✅  Deploy successful!
Preview URL: https://2d0854a1.dwhdelft-nl-u1a.pages.dev
Branch Preview URL: https://thomcsmits-mixup2.dwhdelft-nl-u1a.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95c6a66
Status: ✅  Deploy successful!
Preview URL: https://511f534b.dwhdelft-nl.pages.dev
Branch Preview URL: https://thomcsmits-mixup2.dwhdelft-nl.pages.dev

View logs

@thomcsmits thomcsmits marked this pull request as ready for review November 20, 2024 17:02
Copy link
Member

@casperboone casperboone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two random initial comments, will take a more in-depth look later :)

but at first sight: looks cool! Good reuse of existing things!

dwhdelft.nl/assets/images/photos/mixup/icons/bar.png Outdated Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Outdated Show resolved Hide resolved
</section>

<section class="mixup-colors">
<div class="bg-[url('~/assets/images/photos/mixup/barvisual.jpg')] bg-cover bg-center py-10">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line where the image is used as a background

Copy link
Member

@casperboone casperboone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slightly more in-depth review ;)
Still looks cool overall, a lot of details in my comments. Some more important than other ;)
Let me know if you have any questions!

dwhdelft.nl/assets/images/photos/mixup/barnight.png Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These SVGs look like pngs converted to SVG. Are the original vector files available to create an SVG?

Copy link
Collaborator Author

@thomcsmits thomcsmits Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't have these. I already had to pull these out of a random MIXUP design guide on Drive. I reached out to see if MIXUP has it.

dwhdelft.nl/pages/mixup.vue Show resolved Hide resolved
outsite.nl/assets/images/photos/mixup/barvisual.jpg Outdated Show resolved Hide resolved
dwhdelft.nl/components/pages/mixup/LinkedEvents.vue Outdated Show resolved Hide resolved
dwhdelft.nl/components/pages/mixup/LinkedEvents.vue Outdated Show resolved Hide resolved
dwhdelft.nl/components/pages/mixup/LinkedEvents.vue Outdated Show resolved Hide resolved
dwhdelft.nl/components/pages/mixup/LinkedEvents.vue Outdated Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants