Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIXUP page #625
base: main
Are you sure you want to change the base?
Add MIXUP page #625
Changes from 22 commits
c5cd03f
9e6b9c2
aa1290f
b5edcd0
b7fefd3
787abdc
bf737c3
e3f3c72
4340c75
0c90f41
d043d84
55a5258
b8bbbe7
5920231
d48224d
de7155c
990fd1f
ca57235
e0ed046
0581f9c
eab7163
cbf2e3f
51e54ce
8bd25b1
83dc116
3698448
98109a4
f97077b
2115509
9232d0f
99b6792
ce779e1
1c7819c
dacd842
dabb7bb
5180707
c6ff344
95c6a66
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These SVGs look like pngs converted to SVG. Are the original vector files available to create an SVG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't have these. I already had to pull these out of a random MIXUP design guide on Drive. I reached out to see if MIXUP has it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line where the image is used as a background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
II feel a bit mixed about the style of the highlights. It's a reuse of the ui components that we use to introduce people elsewhere, that is a kind of confusing ui pattern.
Maybe use an
ElementsActionCard
like on the Out-site's highlights? That way the images also come beter tot hun rechtThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. (This was also a request from Colin, so I'll also discuss)
I do think the Outsite highlights look quite a bit like the cards above (with the 4 types of events), so this rounded element gives a nice difference in design.