Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create /logout endpoint #158

Closed
4 tasks done
nelsonic opened this issue Nov 4, 2021 · 2 comments
Closed
4 tasks done

Create /logout endpoint #158

nelsonic opened this issue Nov 4, 2021 · 2 comments
Labels
enhancement New feature or enhancement of existing functionality priority-3 Third priority. Considered "Nice to Have". Not urgent. T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 4, 2021 •
edited
Loading

While implementing the /logout endpoint in the auth_plug_example app: dwyl/auth_plug_example#16
We noted that even though the logout works on localhost the session cookie was still active on the auth App,
so when we click on the admin link, we are automatically/transparently logged back in to the example app on localhost.
See: dwyl/auth_plug#11 (comment)

While we consider this functionality to be a feature (not a "bug") https://en.wikipedia.org/wiki/Undocumented_feature
it still means that logout does not work as we expect in the "consumer" apps using auth_plug. 💭

Todo

  • implement /logout functionality in the auth app using AuthPlug.logout/1
  • update DB
  • expose /session_end endpoint to "consumer" apps using auth_plug
  • tests!!

Related to Session Management #30
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality priority-3 Third priority. Considered "Nice to Have". Not urgent. technical A technical issue that requires understanding of the code, infrastructure or dependencies T2h Time Estimate 2 Hours labels Nov 4, 2021
nelsonic added a commit that referenced this issue Nov 7, 2021
@nelsonic
add app_id, auth_provider and person_id (ref) to sessions table for #158
b6c15f5 
 / rel: #30
This was referenced Nov 7, 2021
Merged
Closed
nelsonic added a commit that referenced this issue Nov 9, 2021
@nelsonic
add app_id, auth_provider and person_id (ref) to sessions table for #158
48166e7 
 / rel: #30
SimonLab added a commit that referenced this issue Nov 11, 2021
@SimonLab
remove session for conusmer app on auth, #158
45d5740
@SimonLab SimonLab mentioned this issue Nov 11, 2021
Merged
nelsonic added a commit that referenced this issue Nov 23, 2021
@nelsonic
add app_id, auth_provider and person_id (ref) to sessions table for #158
cdca4b2 
 / rel: #30
nelsonic added a commit that referenced this issue Nov 23, 2021
@nelsonic
[WiP] use auth_plug 1.4.1 for logout/1 #158
140bef4
nelsonic added a commit that referenced this issue Nov 25, 2021
@nelsonic
add test for failed attempt at GET /end_session for #158 / #30
a2cc4ab
nelsonic added a commit that referenced this issue Nov 26, 2021
@nelsonic
refactor session_end endpoint, handler and tests to accept the sessio…
9e77fbb 
…n_id for #158 / #30 see: #159 (comment)
nelsonic added a commit that referenced this issue Nov 26, 2021
@nelsonic
add Auth.Session.start_session/2 to test_helpers.exs for #158
1b5f7a7
@nelsonic
Copy link
Member Author

PR #159 assigned for review. :shipit:

@nelsonic nelsonic mentioned this issue Nov 26, 2021
Open
13 tasks
@nelsonic
Copy link
Member Author

nelsonic commented Jan 4, 2022

Working on https://authdev.herokuapp.com/
image

image

Closing. ✅

@nelsonic nelsonic closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or enhancement of existing functionality priority-3 Third priority. Considered "Nice to Have". Not urgent. T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic