Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Logout Endpoint/Handler in Example App #15

Closed
nelsonic opened this issue Nov 4, 2021 · 2 comments
Closed

Implement Logout Endpoint/Handler in Example App #15

nelsonic opened this issue Nov 4, 2021 · 2 comments
Assignees
@SimonLab
Labels
awaiting-review enhancement New feature or request T1h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 4, 2021

Even though we don't think this feature has a particularly high priority (for our projects) ... see: dwyl/auth_plug#11
We feel that having it will be useful both for testing purposes
and it will preemptively answer the question some people
will inevitably have when using auth or indeed eventually our App:

"How do I logout...?" 🤷‍♂️
@nelsonic nelsonic added enhancement New feature or request T1h technical labels Nov 4, 2021
nelsonic added a commit that referenced this issue Nov 4, 2021
@nelsonic
add "logout" link to header for #15
f59db7c
nelsonic added a commit that referenced this issue Nov 4, 2021
@nelsonic
add /logout route and controller/handler for #15
ff69e1f
@nelsonic nelsonic mentioned this issue Nov 8, 2021
Merged
1 task
@nelsonic
Copy link
Member Author

nelsonic commented Nov 8, 2021

Need to implement this in auth first: dwyl/auth#158

nelsonic added a commit that referenced this issue Nov 26, 2021
@nelsonic
use auth_plug 1.4.6 with AuthPlug.logout/1 #15
54f13b3
nelsonic added a commit that referenced this issue Nov 26, 2021
@nelsonic
add auth_url to AUTH_API_KEY in ci.yml env #15
53e6cf4
@nelsonic
Copy link
Member Author

Implemented in #16 :shipit:

SimonLab added a commit that referenced this issue Nov 30, 2021
@SimonLab
Merge pull request #16 from dwyl/implement-logout-endpoint-issue-#15
6d04bf4 
logout endpoint  auth_plug_example App issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review enhancement New feature or request T1h technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab