Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing sam's photo #217

Merged
2 commits merged into from
Mar 23, 2017
Merged

changing sam's photo #217

2 commits merged into from
Mar 23, 2017

Conversation

samhstn
Copy link
Member

@samhstn samhstn commented Mar 23, 2017

Changing my photo to a better, smaller one

Relates to #215

@samhstn samhstn added the awaiting-review An issue or pull request that needs to be reviewed label Mar 23, 2017
@samhstn samhstn requested review from nelsonic and SimonLab and removed request for nelsonic and SimonLab March 23, 2017 09:36
@SimonLab
Copy link
Member

Thanks for changing the new picture, the size is better now (87kb 👍 ) but I think the ration is not quiet right:
sam-picture

SimonLab
SimonLab requested changes Mar 23, 2017
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #217 (comment)

@SimonLab SimonLab removed the awaiting-review An issue or pull request that needs to be reviewed label Mar 23, 2017
@SimonLab SimonLab assigned samhstn and unassigned nelsonic and SimonLab Mar 23, 2017
@ghost
Copy link

ghost commented Mar 23, 2017

@Shouston3 it needs to be a square ratio

@samhstn
Copy link
Member Author

samhstn commented Mar 23, 2017

Thanks guys, should be fixed now 👍

SimonLab
SimonLab approved these changes Mar 23, 2017
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shouston3 👍

@SimonLab SimonLab assigned iteles and ghost and unassigned samhstn Mar 23, 2017
@ghost ghost merged commit 8a98755 into master Mar 23, 2017
@ghost ghost deleted the change-sam-photo branch March 23, 2017 11:08
@jammur jammur unassigned ghost Dec 14, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@iteles iteles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samhstn @SimonLab @nelsonic @iteles