Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Updates / Quick Wins #228 #229

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Small Updates / Quick Wins #228 #229

merged 2 commits into from
Jun 1, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2017

#228

Minor updates to site:

  • Removal of Anita
  • Removal of chaggosians reference
  • Formatting updates
  • Updating offering
  • Updating mission

This is not a complete update - there are still many changes that need doing, these are just minor ones that I spotted as I was updating Anita's team status

@ghost ghost requested a review from iteles June 1, 2017 13:52
@ghost ghost assigned iteles Jun 1, 2017
@ghost ghost mentioned this pull request Jun 1, 2017
@ghost ghost added T25m Time Estimate 25 Minutes awaiting-review An issue or pull request that needs to be reviewed labels Jun 1, 2017
@iteles iteles added the in-review Issue or pull request that is currently being reviewed by the assigned person label Jun 1, 2017
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions! 😊

views/index.html Outdated
@@ -1,15 +1,15 @@
<div class="pure-g full-height-block dark-bg splash">
<a href="/team"><div class="splash-container"></div></a>
<div class="pure-u-1 splash-tagline">
<span>dwyl is a <span class="tagline-highlight">team</span> of people using <span class="tagline-highlight">technology</span> to solve real problems</span>
<span>dwyl /dwɪɫ/ is a <span class="tagline-highlight">worldwide community</span> of people using <span class="tagline-highlight">technology</span> to solve real problems.</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone really understand that phonetic thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do...not sure if other people do...this comes from dwyl/video#24 and dwyl/hq#249 - feel free to remove if we don't want it on there!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markwilliamfirth I'll leave it to you to decide whether this looks confusing or not:
screen shot 2017-06-01 at 16 40 25

</p>
</div>
</div>
<div class="pure-u-1 pure-u-md-1-3 flex-center section-box-wrapper">
<div class="section-box">
<div class="offering-icon user-testing-icon">
</div>
<h3>User testing</h3>
<h3>Co-working</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this change given it will only be here for two weeks, but the importance of user testing needs to be highlighted in our new content.
Good to get this on here though 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was against our values to use the word "user" 😆 mentioned "human-centred design" in it's place in training bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊 User testing is a well-known term.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iteles I know it is - I just thought @nelsonic didn't like using the word user - I remember him mentioning it in a meeting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think SEO on this one. We just don't refer to our community as users: https://github.com/dwyl/start-here/blob/master/manifesto.md#we-do-not-have-users-we-have-people

views/index.html Outdated
</p>
<p>
<i>We fully support the <a href="http://www.chagossupport.org.uk/">Chagossians</a> and their right to claim profits from the sale of .io domains associated with their homeland.</i>
Copyright 2016 &copy; DWYL LTD, company number 09525434 registered in England &amp; Wales at 104 Mary Datchelor Close, London SE5 7DY, United Kingdom. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna change this to 2017? 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do next time! As I said there are lots more changes to make 😛

views/index.html Outdated
<p>
We provide professional training for developers in TDD, Node.js and React.
Hands-on, immersive learning designed to enlighten, inspire and empower. Workshops in agile development, product ownership, human-centered design and more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the code to make sure that having a way bigger caption for this picture than the others won't make it look weird or break the styling?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice that - does it do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me 2 mins to pull this branch, npm i && npm start. Always worth running the code you're changing.

screen shot 2017-06-01 at 16 34 08

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want them all the same size?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No... I just want it to not look ugly ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I have to push another commit to this PR? Not sure how to do this...never done this before...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You went through Founders & Coders, of course you have! 😆
Yea, just push another commit to this branch and it will show up in this PR.

@iteles iteles removed awaiting-review An issue or pull request that needs to be reviewed in-review Issue or pull request that is currently being reviewed by the assigned person T25m Time Estimate 25 Minutes labels Jun 1, 2017
@iteles iteles assigned ghost and unassigned iteles Jun 1, 2017
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice pushing 😉
LGTM.

@iteles iteles merged commit 379e333 into master Jun 1, 2017
@iteles iteles deleted the updates branch June 1, 2017 15:54
@ghost
Copy link
Author

ghost commented Jun 1, 2017

:shipit:

@jammur jammur unassigned ghost Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants