Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Docs Enhancements issue #3 #4

Merged
merged 20 commits into from
Jun 20, 2022
Merged

PR: Docs Enhancements issue #3 #4

merged 20 commits into from
Jun 20, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jun 17, 2022 •
edited
Loading

@SimonLab I've gone through your [already great] README.md and added/tidied a few lines. 📝
Hope you don't mind, and hopefully you agree these are enhancements. 🤞

@nelsonic nelsonic added documentation Improvements or additions to documentation T1h Time Estimate 1 Hour in-progress An issue or pull request that is being worked on by the assigned person chore a tedious but necessary task often paying technical debt labels Jun 17, 2022
@nelsonic nelsonic self-assigned this Jun 17, 2022
@nelsonic nelsonic mentioned this pull request Jun 17, 2022
Merged
SimonLab and others added 2 commits June 17, 2022 12:13
@SimonLab
Create Agent for timer state
771ebad 
Use agent to manage the state of the Timer
@nelsonic
add section headings
bc4fe54
@nelsonic
Copy link
Member Author

@SimonLab on the basis that you are working on #5 I will pause this until your work is merged. 👍

@nelsonic nelsonic added the priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished label Jun 17, 2022
SimonLab and others added 11 commits June 17, 2022 14:47
@SimonLab
Use PubSub to sync timer
1d329ba 
Using PubSub to have multiple clients
listening to the stopwatch
@SimonLab
Test Agent stopwatch
595a1a1 
Create test for agent
@SimonLab
Update Readme
f32664c 
Add Agent section in Readme
@SimonLab
Add reset timer feature
7be65c9 
Create a reset function in the Timer agent.
Update the html to display the reset button
and handle the "reset" event with liveview
@nelsonic
semantic line breaks https://sembr.org
151610e
@nelsonic
add gif of colab stopwatch! #3
73593aa
@nelsonic
Merge pull request #5 from dwyl/timer-agent
3dd0b16 
Create Agent for timer state
@nelsonic
add flat-square badges to README.md #3
9564633
@nelsonic
add section headings
5d8cbdc
@nelsonic
add screenshot to README.md #3
23a9dc0
@nelsonic
fix merge conflicts
8952ff4
@nelsonic nelsonic changed the title [WiP] PR: Docs Enhancements issue #3 PR: Docs Enhancements issue #3 Jun 18, 2022
@nelsonic nelsonic mentioned this pull request Jun 18, 2022
Closed
5 tasks
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jun 18, 2022
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Jun 18, 2022
@nelsonic nelsonic requested a review from SimonLab June 18, 2022 09:47
@codecov
Copy link

codecov bot commented Jun 18, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@9e9ef26). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #4   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?        27           
  Branches        ?         0           
========================================
  Hits            ?        27           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9ef26...33312c3. Read the comment docs.

@nelsonic
Copy link
Member Author

Build passing. Coverage 100%. Over to you @SimonLab 👍 [when you're back at your desk on Monday ...]

@nelsonic nelsonic added T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. and removed T1h Time Estimate 1 Hour labels Jun 18, 2022
@SimonLab
Fix markdown title
33312c3 
Update markdown to fix broken title
SimonLab
SimonLab approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the Readme and adding coverage! Looks good

@SimonLab SimonLab merged commit 2617427 into main Jun 20, 2022
@SimonLab SimonLab deleted the enhancements-issue-#3 branch June 20, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab