Create Agent for timer state #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use agent to manage the state of the Timer
SimonLab
added
the
in-progress
SimonLab
commented
Jun 17, 2022
| @@ -13,9 +13,10 @@ defmodule Stopwatch.Application do | |||
| # Start the PubSub system | |||
| {Phoenix.PubSub, name: Stopwatch.PubSub}, | |||
| # Start the Endpoint (http/https) | |||
| StopwatchWeb.Endpoint | |||
| StopwatchWeb.Endpoint, | |||
There was a problem hiding this comment.
The application will create the timer by calling Stopwatch.Timer.start_link\1 function
SimonLab
commented
Jun 17, 2022
lib/stopwatch/timer.ex
Outdated
| use Agent | ||
|
|
||
| def start_link(_opts) do | ||
| Agent.start_link(fn -> ~T[00:00:00] end, name: __MODULE__) |
There was a problem hiding this comment.
Module name are atoms so we can use it as the name for the timer agent
Using PubSub to have multiple clients listening to the stopwatch
Create test for agent
|
The stopwatch state is now shared between client using Agent. This can be tested at https://liveview-stopwatch.fly.dev/ |
Add Agent section in Readme
SimonLab
added
awaiting-review
|
@nelsonic let me know if all this makes sense, thanks |
5 tasks
nelsonic
added
in-review
Create a reset function in the Timer agent. Update the html to display the reset button and handle the "reset" event with liveview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use agent to manage the state of the Timer