[OTE-221] Add query for PendingSendPacket #1176

affanv14 · 2024-03-14T20:24:19Z

Changelist

Adds a query endpoint to check number of pending send packets

Test Plan

Added unit test to check query endpoint
Added integration test for cobra to check if response threw an error
ran a local testnet and queried for sanity

Author/Reviewer Checklist

If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
Manually add any of the following labels: refactor, chore, bug.

coderabbitai · 2024-03-14T20:24:27Z

Walkthrough

The update enhances the rate limit module by introducing features to manage pending send packets efficiently. It includes new RPC methods, CLI commands, keeper functions, and types to facilitate the retrieval and processing of pending send packets within the Dydx Protocol ecosystem.

Changes

Files	Change Summary
`dydxprotocol/ratelimit`	Reordered and renamed imports for various functionalities like ratelimit, rewards, sending, stats, subaccounts, vault, and vest.
`dydxprotocol/ratelimit/pending_send_packet.ts`	Introduces `PendingSendPacket` interface and functions for packet encoding, decoding, and instance creation with channel ID and sequence info.
`dydxprotocol/ratelimit/query.lcd.ts`	Added `allPendingSendPackets` function to `LCDQueryClient` class for retrieving all pending send packets.
`dydxprotocol/ratelimit/query.rpc.Query.ts`	Added `allPendingSendPackets` function to `Query` interface and its implementation in `QueryClientImpl` with related request and response types.
`dydxprotocol/ratelimit/query.ts`	Introduced interfaces and functions for `QueryAllPendingSendPacketsRequest` and `QueryAllPendingSendPacketsResponse`, along with encoding and decoding functions. Updated response handling for `PendingSendPacket` data.
`gogoproto/bundle.ts`	Updated import statement from `_103` to `_104` affecting the `gogoproto` constant.
`google/bundle.ts`	Reordered and added imports, updated structure of `google` namespace by adjusting `api` and `protobuf` objects.
`protocol/x/ratelimit/types/keys.go`	Updated to import additional packages (`bytes` and `strconv`) and introduce `SplitPendingSendPacketKey` function for splitting a byte key into `channelId` and `sequenceNumber`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 20ffef4 and a8bd15f.

Files ignored due to path filters (3)

protocol/x/ratelimit/types/pending_send_packet.pb.go is excluded by: !**/*.pb.go
protocol/x/ratelimit/types/query.pb.go is excluded by: !**/*.pb.go
protocol/x/ratelimit/types/query.pb.gw.go is excluded by: !**/*.pb.gw.go

Files selected for processing (8)

proto/dydxprotocol/ratelimit/pending_send_packet.proto (1 hunks)
proto/dydxprotocol/ratelimit/query.proto (3 hunks)
protocol/x/ratelimit/client/cli/pending_send_packets.go (1 hunks)
protocol/x/ratelimit/client/cli/pending_send_packets_test.go (1 hunks)
protocol/x/ratelimit/client/cli/query.go (1 hunks)
protocol/x/ratelimit/keeper/grpc_query.go (2 hunks)
protocol/x/ratelimit/keeper/grpc_query_test.go (1 hunks)
protocol/x/ratelimit/types/keys.go (2 hunks)

Additional comments: 4

proto/dydxprotocol/ratelimit/pending_send_packet.proto (1)

1-12: The protobuf definition for PendingSendPacket is well-structured and clearly documented. The use of string for channel_id and uint64 for sequence is appropriate for their intended purposes. The overall structure adheres to best practices for protobuf definitions.

protocol/x/ratelimit/client/cli/query.go (1)

25-25: The addition of CmdPendingSendPackets() to the GetQueryCmd function is correctly implemented and follows the established pattern for adding new CLI commands. This enhances the module's query capabilities by providing a direct way to query pending send packets.

protocol/x/ratelimit/client/cli/pending_send_packets_test.go (1)

17-30: The test case for CmdPendingSendPackets is correctly implemented and verifies the command's ability to return an empty list of pending send packets. To ensure comprehensive coverage, consider adding more test scenarios, particularly for cases where pending send packets exist in the system.

protocol/x/ratelimit/client/cli/pending_send_packets.go (1)

10-34: The implementation of the CmdPendingSendPackets CLI command is well-structured and adheres to Cosmos SDK standards. The command setup and execution logic are correctly implemented, providing a straightforward way for users to query all pending send packets.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a8bd15f and 6b21e65.

Files ignored due to path filters (1)

protocol/go.mod is excluded by: !**/*.mod

Files selected for processing (2)

proto/dydxprotocol/ratelimit/pending_send_packet.proto (1 hunks)
proto/dydxprotocol/ratelimit/query.proto (3 hunks)

Files skipped from review as they are similar to previous changes (2)

proto/dydxprotocol/ratelimit/pending_send_packet.proto
proto/dydxprotocol/ratelimit/query.proto

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6b21e65 and 9a7a4a1.

Files ignored due to path filters (2)

protocol/x/ratelimit/types/pending_send_packet.pb.go is excluded by: !**/*.pb.go
protocol/x/ratelimit/types/query.pb.go is excluded by: !**/*.pb.go

Files selected for processing (3)

proto/dydxprotocol/ratelimit/pending_send_packet.proto (1 hunks)
proto/dydxprotocol/ratelimit/query.proto (3 hunks)
protocol/x/ratelimit/module_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (2)

proto/dydxprotocol/ratelimit/pending_send_packet.proto
proto/dydxprotocol/ratelimit/query.proto

Additional comments: 1

protocol/x/ratelimit/module_test.go (1)

135-138: The update to TestAppModuleBasic_GetQueryCmd correctly reflects the addition of the "pending-send-packets" command, aligning with the PR's objective to enhance the ratelimit module with a new query endpoint. It's crucial to keep tests updated to cover new functionalities, ensuring the reliability of the module.

proto/dydxprotocol/ratelimit/query.proto

protocol/x/ratelimit/types/keys.go

teddyding · 2024-03-19T14:56:25Z

protocol/x/ratelimit/types/keys.go

+func SplitPendingSendPacketKey(key []byte) (channelId string, sequenceNumber uint64) {
+	parts := bytes.Split(key, []byte("_"))
+	if len(parts) != 2 {
+		panic(fmt.Sprintf("unexpected key format: %s", key))


What does user see if we panic here? I assume nothing or some internal error?

Let's:

Log an error here so we could see this on server side

Also return this error so the user can see this error as well (easier for troubleshooting)

The error string could also be more helpful (e.g. "unexpected PendingSendPacket key format...")

Co-authored-by: Teddy Ding <teddy@dydx.exchange>

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9a7a4a1 and e1390d4.

Files selected for processing (1)

protocol/x/ratelimit/types/keys.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

protocol/x/ratelimit/types/keys.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e1390d4 and 34c1fc9.

Files ignored due to path filters (2)

protocol/x/ratelimit/types/query.pb.go is excluded by: !**/*.pb.go
protocol/x/ratelimit/types/query.pb.gw.go is excluded by: !**/*.pb.gw.go

Files selected for processing (7)

proto/dydxprotocol/ratelimit/query.proto (3 hunks)
protocol/x/ratelimit/client/cli/pending_send_packets.go (1 hunks)
protocol/x/ratelimit/client/cli/pending_send_packets_test.go (1 hunks)
protocol/x/ratelimit/keeper/grpc_query.go (2 hunks)
protocol/x/ratelimit/keeper/grpc_query_test.go (1 hunks)
protocol/x/ratelimit/types/keys.go (2 hunks)
protocol/x/ratelimit/types/keys_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (7)

proto/dydxprotocol/ratelimit/query.proto
protocol/x/ratelimit/client/cli/pending_send_packets.go
protocol/x/ratelimit/client/cli/pending_send_packets_test.go
protocol/x/ratelimit/keeper/grpc_query.go
protocol/x/ratelimit/keeper/grpc_query_test.go
protocol/x/ratelimit/types/keys.go
protocol/x/ratelimit/types/keys_test.go

linear · 2024-03-21T14:25:33Z

OTE-221 Add query for `PendingSendPacket`

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 34c1fc9 and 033b243.

Files selected for processing (7)

indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts (4 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/pending_send_packet.ts (1 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.lcd.ts (3 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.rpc.Query.ts (5 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.ts (3 hunks)
indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts (1 hunks)
indexer/packages/v4-protos/src/codegen/google/bundle.ts (1 hunks)

Additional comments: 9

indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts (1)

1-2: The update from _101 to _102 in the import statement seems to be a straightforward change, likely due to a version update or reorganization of the source modules. Ensure that all necessary exports from _102 are being used as expected.

indexer/packages/v4-protos/src/codegen/google/bundle.ts (1)

1-14: The reordering and addition of imports, along with the adjustments to the google namespace, appear to be well-structured and necessary for the functionality. Ensure that all newly added imports are used appropriately and that the namespace adjustments correctly represent the intended structure.

indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.lcd.ts (2)

14-14: Binding the new allPendingSendPackets function in the constructor is a good practice for maintaining the correct this context. Ensure that the endpoint used in the function is correctly implemented and tested.

41-43: The implementation of the allPendingSendPackets function appears to correctly use the endpoint for fetching data. Ensure that the functionality has been thoroughly tested, especially the handling of different response scenarios.

indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/pending_send_packet.ts (1)

8-37: The PendingSendPacket interfaces and their associated encode/decode functions are well-structured and follow the protobuf specification. Ensure that the field types and encode/decode logic have been correctly implemented and tested.

indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.rpc.Query.ts (2)

13-15: Adding the allPendingSendPackets function to the Query interface and its implementation in QueryClientImpl enhances the functionality. Ensure that the RPC request handling in the implementation is correctly done and thoroughly tested.

39-42: The implementation of the allPendingSendPackets function in QueryClientImpl appears to correctly handle the RPC request. Ensure that the functionality has been thoroughly tested, especially the handling of different response scenarios.

indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts (1)

66-173: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [69-322]

The reordering and renaming of imports in the dydxprotocol namespace appear to be well-structured and necessary for the functionality. Ensure that all references to the renamed and reordered imports are valid and that the changes have been thoroughly tested.

indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.ts (1)

255-337: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [62-335]

The addition of QueryAllPendingSendPacketsRequest and QueryAllPendingSendPacketsResponse interfaces, along with their encode/decode functions, enhances the functionality for querying all pending send packets. Ensure that the field types and encode/decode logic have been correctly implemented and thoroughly tested.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 34c1fc9 and 9f76806.

Files ignored due to path filters (1)

protocol/go.mod is excluded by: !**/*.mod

Files selected for processing (7)

indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts (4 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/pending_send_packet.ts (1 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.lcd.ts (3 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.rpc.Query.ts (5 hunks)
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.ts (3 hunks)
indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts (1 hunks)
indexer/packages/v4-protos/src/codegen/google/bundle.ts (1 hunks)

Files skipped from review as they are similar to previous changes (6)

indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/pending_send_packet.ts
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.lcd.ts
indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.rpc.Query.ts
indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts
indexer/packages/v4-protos/src/codegen/google/bundle.ts

Additional comments: 4

indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/query.ts (4)

67-73: The addition of QueryAllPendingSendPacketsRequest and QueryAllPendingSendPacketsRequestSDKType interfaces is clear and follows the established pattern for request types in this codebase. This aligns with the PR's objective to introduce a query endpoint for pending send packets.

79-87: The QueryAllPendingSendPacketsResponse and QueryAllPendingSendPacketsResponseSDKType interfaces are well-defined, with a clear focus on encapsulating the pending send packets data. This structure is essential for the functionality introduced by the PR, ensuring that the response data is correctly typed and accessible.

264-291: The implementation of the encode, decode, and fromPartial functions for QueryAllPendingSendPacketsRequest follows the established conventions in this codebase. These functions are crucial for the serialization and deserialization of the request data, ensuring compatibility with the underlying protobufjs library.

300-335: The encode, decode, and fromPartial functions for QueryAllPendingSendPacketsResponse are implemented correctly, ensuring that the response data can be serialized and deserialized effectively. This is crucial for the integration of the new query endpoint with the rest of the system, facilitating the retrieval and processing of pending send packets data.

protocol/x/ratelimit/types/keys.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f76806 and cdc0d7f.

Files selected for processing (1)

protocol/x/ratelimit/types/keys.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

protocol/x/ratelimit/types/keys.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f76806 and d76e666.

Files selected for processing (1)

protocol/x/ratelimit/types/keys.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

protocol/x/ratelimit/types/keys.go

* Add query for PendingSendPacket * update go.mod * lint fixes * newline * protos * proto stuff * update tests * Update protocol/x/ratelimit/types/keys.go Co-authored-by: Teddy Ding <teddy@dydx.exchange> * address comments * add error handling * indexer protos * nit --------- Co-authored-by: Teddy Ding <teddy@dydx.exchange> (cherry picked from commit e545bbf) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts # indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts # indexer/packages/v4-protos/src/codegen/google/bundle.ts # protocol/go.mod

--------- Co-authored-by: Teddy Ding <teddy@dydx.exchange> (cherry picked from commit e545bbf) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts # indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts # indexer/packages/v4-protos/src/codegen/google/bundle.ts # protocol/go.mod * fix protos * update go.mod --------- Co-authored-by: Mohammed Affan <affanmd@nyu.edu> Co-authored-by: affan <affan@dydx.exchange>

* [OTE-221] Add query for PendingSendPacket (backport #1176) (#1221) --------- Co-authored-by: Teddy Ding <teddy@dydx.exchange> (cherry picked from commit e545bbf) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts # indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts # indexer/packages/v4-protos/src/codegen/google/bundle.ts # protocol/go.mod * fix protos * update go.mod --------- Co-authored-by: Mohammed Affan <affanmd@nyu.edu> Co-authored-by: affan <affan@dydx.exchange> * [Backport v4.x] backport full node streaming to v4.x branch (#1270) * [CT-645] Move off chain updates and v1 to a different package (#1131) * [CT-645] Add protos for orderbook stream query service * move removal reasons to a separate package * [CT-645] Add protos for orderbook stream query service (#1133) * [CT-645] Add protos for orderbook stream query service * make update not nullable * fix build * [CT-644] instantiate grpc stream manager (#1134) * [CT-644] instantiate grpc stream manager * update type * update channel type * [CT-646] stream offchain updates through stream manager (#1138) * [CT-646] stream offchain updates through stream manager * comments * fix lint * get rid of finished * comments * comments * [CT-652] add command line flag for full node streaming (#1145) * [CT-647] construct the initial orderbook snapshot (#1147) * [CT-647] construct the initial orderbook snapshot * [CT-647] initialize new streams and send orderbook snapshot (#1152) * [CT-647] initialize new streams and send orderbook snapshot * use sync once * comments * [CT-700] separate indexer and grpc streaming events (#1209) * [CT-700] separate indexer and grpc streaming events * fix tests * comments * update * [CT-700] only send response when there is at least one update (#1216) * [CT-712] send order update when short term order state fill amounts are pruned (#1241) * [CT-712] send fill amount updates for reverted operations (#1240) * [CT-723] add block number + stage to grpc updates (#1252) * [CT-723] add block number + stage to grpc updates * add indexer changes * [CT-727] avoid state reads when sending updates (#1261) * [CT-712] send updates for both normal order matches and liquidation (#1280) (#1281) * Fix lib.ErrorLogWithError: properly pass in args (#1306) (#1310) (cherry picked from commit a91c1ca) Co-authored-by: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> * fix broken tests (#1312) (#1316) (cherry picked from commit 5ec37d2) Co-authored-by: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mohammed Affan <affanmd@nyu.edu> Co-authored-by: affan <affan@dydx.exchange> Co-authored-by: jayy04 <103467857+jayy04@users.noreply.github.com> Co-authored-by: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com>

Add query for PendingSendPacket

a8bd15f

github-actions bot added protocol proto labels Mar 14, 2024

affanv14 requested a review from teddyding March 14, 2024 20:25

affanv14 added 2 commits March 14, 2024 16:26

update go.mod

62c2fcb

lint fixes

6b21e65

coderabbitai bot reviewed Mar 14, 2024

View reviewed changes

affanv14 added 2 commits March 14, 2024 16:34

newline

813c4e7

protos

3e20e3d

coderabbitai bot reviewed Mar 14, 2024

View reviewed changes

affanv14 added 2 commits March 14, 2024 16:40

proto stuff

fb72200

update tests

9a7a4a1

coderabbitai bot reviewed Mar 15, 2024

View reviewed changes

teddyding reviewed Mar 19, 2024

View reviewed changes

proto/dydxprotocol/ratelimit/query.proto Outdated Show resolved Hide resolved

teddyding reviewed Mar 19, 2024

View reviewed changes

protocol/x/ratelimit/types/keys.go Outdated Show resolved Hide resolved

teddyding reviewed Mar 19, 2024

View reviewed changes

protocol/x/ratelimit/types/keys.go Outdated Show resolved Hide resolved

teddyding reviewed Mar 19, 2024

View reviewed changes

Update protocol/x/ratelimit/types/keys.go

e1390d4

Co-authored-by: Teddy Ding <teddy@dydx.exchange>

coderabbitai bot reviewed Mar 19, 2024

View reviewed changes

address comments

17e10b3

affanv14 force-pushed the affan/psp-query branch from 4dba64a to adaa83b Compare March 19, 2024 21:09

add error handling

34c1fc9

affanv14 force-pushed the affan/psp-query branch from adaa83b to 34c1fc9 Compare March 19, 2024 21:10

coderabbitai bot reviewed Mar 19, 2024

View reviewed changes

github-actions bot added the indexer label Mar 21, 2024

affanv14 changed the title ~~Add query for PendingSendPacket~~ [OTE-221] Add query for PendingSendPacket Mar 21, 2024

affanv14 added 2 commits March 21, 2024 10:26

Merge remote-tracking branch 'origin/main' into affan/psp-query

0f1822f

indexer protos

9f76806

affanv14 force-pushed the affan/psp-query branch from 033b243 to 9f76806 Compare March 21, 2024 14:27

coderabbitai bot reviewed Mar 21, 2024

View reviewed changes

teddyding reviewed Mar 21, 2024

View reviewed changes

protocol/x/ratelimit/types/keys.go Outdated Show resolved Hide resolved

teddyding reviewed Mar 21, 2024

View reviewed changes

protocol/x/ratelimit/types/keys.go Outdated Show resolved Hide resolved

teddyding approved these changes Mar 21, 2024

View reviewed changes

affanv14 added the backport/protocol/v4.x label Mar 22, 2024

nit

d76e666

affanv14 force-pushed the affan/psp-query branch from cdc0d7f to d76e666 Compare March 22, 2024 14:38

coderabbitai bot reviewed Mar 22, 2024

View reviewed changes

affanv14 merged commit e545bbf into main Mar 22, 2024
32 checks passed

affanv14 deleted the affan/psp-query branch March 22, 2024 15:10

mergify bot mentioned this pull request Mar 22, 2024

[OTE-221] Add query for PendingSendPacket (backport #1176) #1221

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OTE-221] Add query for PendingSendPacket #1176

[OTE-221] Add query for PendingSendPacket #1176

affanv14 commented Mar 14, 2024 •

edited

Loading

coderabbitai bot commented Mar 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

teddyding Mar 19, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

linear bot commented Mar 21, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

[OTE-221] Add query for PendingSendPacket #1176

[OTE-221] Add query for PendingSendPacket #1176

Conversation

affanv14 commented Mar 14, 2024 • edited Loading

Changelist

Test Plan

Author/Reviewer Checklist

coderabbitai bot commented Mar 14, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

teddyding Mar 19, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

linear bot commented Mar 21, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

affanv14 commented Mar 14, 2024 •

edited

Loading

coderabbitai bot commented Mar 14, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)