[CT-700] only send response when there is at least one update

[jayy04]

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[linear]

CT-700 Fix indexer offchain events

[coderabbitai]

Walkthrough

The recent update focuses on optimizing the efficiency of the GrpcStreamingManagerImpl by refining the SendOrderbookUpdates method. This adjustment ensures that orderbook updates are only transmitted when necessary, effectively eliminating redundant data transmission in scenarios where there are no new updates. This change enhances the performance and resource utilization of the system by avoiding unnecessary network and processing overhead.

Changes

File	Summary
.../grpc/grpc_streaming_manager.go	Adjusted SendOrderbookUpdates to only send updates when available, optimizing performance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f5556ac and f7b7afb.

Files selected for processing (1)

• protocol/streaming/grpc/grpc_streaming_manager.go (1 hunks)

Additional comments: 1

protocol/streaming/grpc/grpc_streaming_manager.go (1)

• 113-121: The changes from lines 113 to 121 effectively implement the PR's objective by ensuring updates are only sent when there are updates to send. This optimization should reduce unnecessary network traffic and computational overhead.

However, consider the following points for further enhancement:

• Error Handling: When subscription.srv.Send fails, the subscription is marked for removal. It might be beneficial to log this error or notify a monitoring system to aid in debugging and operational monitoring.
• Memory Optimization: The updatesToSend slice is created for each subscription, even if it ends up being empty. While this is optimized by the new conditional check, consider pre-allocating this slice based on the expected number of updates or exploring other memory optimization techniques if this method becomes a bottleneck.

Overall, the changes align well with the PR's objectives and should contribute positively to the system's efficiency.