Fix binding of +Infinity, -Infinity, -0, and extremely large number values #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyedgreen
requested changes
Nov 1, 2020
There was a problem hiding this comment.
Thank you so much for the PR! Looking pretty good so far. One thing I would like to change is to drop the -0 case.
SQLite serializes REAL values in tables in such a way that the -0 becomes a +0 regardless, so the check does not really do anything in practice. 😅
I left a couple of comments on how to structure the test cases as well. Happy to merge once those are addressed. 😅
|
LGTM 😍 Thank you @jeremyBanks for flagging this issue and the quick fix! |
dyedgreen
approved these changes
Nov 2, 2020
atsjj
added a commit
to atsjj/cotton
that referenced
this pull request
Nov 20, 2020
* MySQL has been bumped to address the `v` prefix deprecation bug. * Sqlite has been bumped to take advantages upstream, see dyedgreen/deno-sqlite#94 and dyedgreen/deno-sqlite#91. * Bumped Dockerfile deno base from `1.4.4` to `1.5.2`, which is the latest available container at the time of this PR.
atsjj
added a commit
to atsjj/cotton
that referenced
this pull request
Nov 20, 2020
* MySQL has been bumped to address the `v` prefix deprecation bug. * Sqlite has been bumped to take advantages upstream, see dyedgreen/deno-sqlite#94 and dyedgreen/deno-sqlite#91. * Bumped Dockerfile deno base from `1.4.4` to `1.5.2`, which is the latest available container at the time of this PR.
rahmanfadhil
pushed a commit
to rahmanfadhil/cotton
that referenced
this pull request
Nov 21, 2020
* MySQL has been bumped to address the `v` prefix deprecation bug. * Sqlite has been bumped to take advantages upstream, see dyedgreen/deno-sqlite#94 and dyedgreen/deno-sqlite#91. * Bumped Dockerfile deno base from `1.4.4` to `1.5.2`, which is the latest available container at the time of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89
Fixes and adds tests the incorrect binding of
+Infinity,-Infinity,-0, and extremely-largenumbervalues, by only binding toINTEGERfor values which satisfy(Number.isSafeInteger(value) && !Object.is(value, -0)), instead of(Math.floor(value) === value).In order to be preserve
-0, we have to bind it as aREALinstead of anINTEGERlike+0. As far as I can tell, this should be harmless.A change in behaviour to call out: integer number values more massive than
MAX_SAFE_INTEGERwhich could fit into anINTEGERwill now be stored asREALinstead ofINTEGER. I could go either way on this, but settled with this because you're usually not supposed to be treating values larger thanMAX_SAFE_INTEGERas integers, even if they happen to fall on integer values.If you want to maintain them as
INTEGER, I think you could change the condition to something like(Number.isFinite(value) && !Object.is(value, -0) && Math.floor(value) === value && -9_223_372_036_854_775_808 <= value && value <= 9_223_372_036_854_775_807)instead.