Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped MySQL and Sqlite Deps #28

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Conversation

atsjj
Copy link
Contributor

@atsjj atsjj commented Nov 20, 2020

@atsjj
Copy link
Contributor Author

atsjj commented Nov 20, 2020

Hello!

I was wanting to try out this project and I ran into some snags. I'm using my fork to get by in the meantime, but I wanted to offer the PR.

Thanks for the project!

Copy link
Owner

@rahmanfadhil rahmanfadhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you so much! 😃

I recently merged another PR, and apparently, it generates a conflict in deps.ts. Can you please solve it first before I can merge it? Thanks!

* MySQL has been bumped to address the `v` prefix deprecation bug.
* Sqlite has been bumped to take advantages upstream, see dyedgreen/deno-sqlite#94
  and dyedgreen/deno-sqlite#91.
* Bumped Dockerfile deno base from `1.4.4` to `1.5.2`, which is the latest available
  container at the time of this PR.
@atsjj
Copy link
Contributor Author

atsjj commented Nov 20, 2020

I rebased my PR for you and resolved the conflict.

@atsjj atsjj requested a review from rahmanfadhil November 20, 2020 14:01
Copy link
Owner

@rahmanfadhil rahmanfadhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 😃

@rahmanfadhil rahmanfadhil merged commit 4ddc956 into rahmanfadhil:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants