[WIP] Switch to Microsoft.Azure.ServiceBus #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may as well tag/fork/whatever the last build that supports SBWS for
anyone that cares and move on
…On Wed, May 30, 2018 at 9:45 AM, Drew Freyling ***@***.***> wrote:
@0xced <https://github.com/0xced> love the work you have done here. The
downside of this is that it removes support of on premise Windows Service
Bus. Having said that, WSB is dead
<https://stackoverflow.com/a/38769190/122880> so now should be the time
we consider to drop support for it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#91 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA71rI4TXPDndxgVrysEtMx1G295kCOOks5t3d2FgaJpZM4USSA5>
.
|
|
@0xced Mossharbor.AzureWorkArounds.ServiceBus GetQueues and GetTopics should be available in version *.15 through nuget, thanks to your pull request. |
0xced
force-pushed
the
Microsoft.Azure.ServiceBus
branch
from
01e4971 to
83e7ee7
Compare
|
Like #93, passing continuous integration testing would require to upgrade AppVeyor image to a more recent version of Visual Studio. Current issue:
|
0xced
force-pushed
the
Microsoft.Azure.ServiceBus
branch
2 times, most recently
from
ce8b49c to
e91fdfd
Compare
The [`Microsoft.Azure.ServiceBus`](https://www.nuget.org/packages/Microsoft.Azure.ServiceBus/) package conforms to .NET Standard and thus works fine on Linux and macOS (using Mono). The WindowsAzure.ServiceBus package can't run on Mono since it depends on kernel32.dll. Required incidental changes: * Upgrade target framework from v4.6 to v4.7.1 * Swith to async code * Upgrade `Newtonsoft.Json` from version 9 to version 10 * Delete IsBodyConsumed and State for which I have found no equivalent * Take a dependency on `Mossharbor.AzureWorkArounds.ServiceBus` since management is not (yet) supported with a service bus connection string, see Azure/azure-service-bus-dotnet#65 * Use a local version of `Mossharbor.AzureWorkArounds.ServiceBus` since `GetQueues()` and `GetTopics()` are not implemented in the published package Mossharbor/AzureWorkArounds.ServiceBus#6
Continuous integration on AppVeyor uses C# 5
Microsoft.Azure.ServiceBus now provides this feature with `EntityNameHelper.FormatDeadLetterPath()`
This was omitted when refactoring to use Microsoft.Azure.ServiceBus
The features of Serilog.Sinks.Literate have now been merged into the default Serilog console sink. The motivation behind this change is to be able to easily change the theme `WriteTo.Console(theme: ConsoleTheme.None)` so that the output in the JetBrains Rider console isn't white text on white background.
The Microsoft.Azure.ServiceBus library targets .NET Standard 2.0 which is actually compatible with .NET Framework 4.6.1, see https://github.com/dotnet/standard/blob/release/2.0.0/docs/versions.md
0xced
force-pushed
the
Microsoft.Azure.ServiceBus
branch
from
e91fdfd to
43c8a10
Compare
0xced
force-pushed
the
Microsoft.Azure.ServiceBus
branch
from
43c8a10 to
bd84777
Compare
|
Note: dependency on |
@lukeschafer done - https://github.com/GlobalX/SbManager/tree/WSB |
|
Now that WSB is out of the way this PR can proceed. |
Although the [documentation (Additions to the csproj format for .NET Core)][1] seems to imply that this is a .NET Core feature, it works with .NET Framework too and is much easier to maintain. With this commit, the OctoPack feature is gone because the new .csproj format is not yet supported by OctoPack. Here is the [suggested workaround][2]: > We have this support on our radar, but don't have an ETA at this stage. In the meantime, you could try running `dotnet publish` and then run `octo.exe pack` against the publish output folder. [1]: https://docs.microsoft.com/en-us/dotnet/core/tools/csproj [2]: OctopusDeploy/Issues#3822 (comment) # Conflicts: # src/SbManager/SbManager.csproj # src/SbManager/packages.config
Drop Mossharbor.AzureWorkArounds.ServiceBus now that management operations are supported in the Microsoft.Azure.ServiceBus library.
Since WindowsService doesn't use the `HostControl` parameter, we can use IService directly.
|
Could you please update the AppVeyor configuration to use VS 2017 instead of VS 2015? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Microsoft.Azure.ServiceBuspackage conforms to .NET Standard and thus works fine on Linux and macOS (using Mono). The WindowsAzure.ServiceBus package can't run on Mono since it depends on kernel32.dll.Required incidental changes:
Newtonsoft.Jsonfrom version 9 to version 11Mossharbor.AzureWorkArounds.ServiceBussince management is not (yet) supported with a service bus connection string, see Management Operations Azure/azure-service-bus-dotnet#65Use a local version ofMossharbor.AzureWorkArounds.ServiceBussinceGetQueues()andGetTopics()are not implemented in the published package Implement NamespaceManager GetQueues() and GetTopics() Mossharbor/AzureWorkArounds.ServiceBus#6Note that this pull request is not ready to merge because of the local version ofMossharbor.AzureWorkArounds.ServiceBuswhich must be downloaded and compiled on its own.