[Do not merge] Convert solution to the new csproj format #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed with this error:
So I tried to add an |
0xced
force-pushed
the
Project-Sdk
branch
4 times, most recently
from
d1c83bf to
6f47081
Compare
The [`Microsoft.Azure.ServiceBus`](https://www.nuget.org/packages/Microsoft.Azure.ServiceBus/) package conforms to .NET Standard and thus works fine on Linux and macOS (using Mono). The WindowsAzure.ServiceBus package can't run on Mono since it depends on kernel32.dll. Required incidental changes: * Upgrade target framework from v4.6 to v4.7.1 * Swith to async code * Upgrade `Newtonsoft.Json` from version 9 to version 10 * Delete IsBodyConsumed and State for which I have found no equivalent * Take a dependency on `Mossharbor.AzureWorkArounds.ServiceBus` since management is not (yet) supported with a service bus connection string, see Azure/azure-service-bus-dotnet#65 * Use a local version of `Mossharbor.AzureWorkArounds.ServiceBus` since `GetQueues()` and `GetTopics()` are not implemented in the published package Mossharbor/AzureWorkArounds.ServiceBus#6
Continuous integration on AppVeyor uses C# 5
Microsoft.Azure.ServiceBus now provides this feature with `EntityNameHelper.FormatDeadLetterPath()`
This was omitted when refactoring to use Microsoft.Azure.ServiceBus
The features of Serilog.Sinks.Literate have now been merged into the default Serilog console sink. The motivation behind this change is to be able to easily change the theme `WriteTo.Console(theme: ConsoleTheme.None)` so that the output in the JetBrains Rider console isn't white text on white background.
The Microsoft.Azure.ServiceBus library targets .NET Standard 2.0 which is actually compatible with .NET Framework 4.6.1, see https://github.com/dotnet/standard/blob/release/2.0.0/docs/versions.md
Although the [documentation (Additions to the csproj format for .NET Core)][1] seems to imply that this is a .NET Core feature, it works with .NET Framework too and is much easier to maintain. With this commit, the OctoPack feature is gone because the new .csproj format is not yet supported by OctoPack. Here is the [suggested workaround][2]: > We have this support on our radar, but don't have an ETA at this stage. In the meantime, you could try running `dotnet publish` and then run `octo.exe pack` against the publish output folder. [1]: https://docs.microsoft.com/en-us/dotnet/core/tools/csproj [2]: OctopusDeploy/Issues#3822 (comment) # Conflicts: # src/SbManager/SbManager.csproj # src/SbManager/packages.config
|
Still need the pipeline changed for this PR? I was hesitant to initially but no direction has changed to make this azure only I'm happy to make the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the documentation (Additions to the csproj format for .NET Core) seems to imply that this is a .NET Core feature, it works with .NET Framework too and is much easier to maintain.
With this commit, the OctoPack feature is gone, it will need some work to reintegrate.
Note that this pull request depends on #91 to be merged first and should be rebased before merging.