Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
fix(filter-field): Reverts a commit that introduced a bug when select…
Browse files Browse the repository at this point in the history
…ing suggestion values.

Fixes #1632

This reverts commit bb129d9.
  • Loading branch information
samuelfahrngruber authored and Lukas Holzer committed Sep 23, 2020
1 parent 9aabaae commit 4ad27e0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
14 changes: 0 additions & 14 deletions libs/barista-components/filter-field/src/filter-field.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,20 +252,6 @@ describe('DtFilterField', () => {
});
});

describe('focus loss', () => {
it('should clear the current input value', fakeAsync(() => {
const input = fixture.debugElement.query(By.css('.dt-filter-field-input'))
.nativeElement;

filterField.focus();
typeIntoFilterElement('foo');
input.blur();
tick();

expect(input.value).toBe('');
}));
});

describe('disabled', () => {
it('should disable the input if filter field is disabled', () => {
// when
Expand Down
4 changes: 0 additions & 4 deletions libs/barista-components/filter-field/src/filter-field.ts
Original file line number Diff line number Diff line change
Expand Up @@ -538,10 +538,6 @@ export class DtFilterField<T = any>
// Assign the currently open filter field when it is focused.
if (this._isFocused) {
currentlyOpenFilterField = this;
} else {
// Clear pending input values on focus loss to communicate that the input
// wasn't applied as a filter
this._writeInputValue('');
}
});

Expand Down

0 comments on commit 4ad27e0

Please sign in to comment.