Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Filter field] suggestions list disappear after clicking on one of suggested entries #1632

Closed
pawel-bugalski-dynatrace opened this issue Sep 17, 2020 · 1 comment · Fixed by #1650
Closed

[Filter field] suggestions list disappear after clicking on one of suggested entries #1632

pawel-bugalski-dynatrace opened this issue Sep 17, 2020 · 1 comment · Fixed by #1650
Labels
bug A broken behaviour that was working previously filter-field Temporary label for filter field issues

Comments

@pawel-bugalski-dynatrace
Copy link

pawel-bugalski-dynatrace commented Sep 17, 2020 •
edited
Loading

Bug Report

Expected Behavior

After clicking on an item in a list it should be field into the filter field

Current Behavior

Suggestions list disappear (note that pressing enter does work).

Steps to Reproduce

Screen Recording 2020-09-17 at 14 49 51

This is reproduced in a demo barista app but not in stackblitz (as on the time of writing it has a too old varsion)
http://localhost:4200/filter-field-default-example

Context (Environment)

Used Versions:

  • node:
  • npm:
  • typescript:
  • angular:
  • @angular/cdk:
  • @dynatrace/barista-components:

Detailed Description

This seems to be a regression caused by #1625

Possible Implementation

Attachments
@pawel-bugalski-dynatrace pawel-bugalski-dynatrace added the bug A broken behaviour that was working previously label Sep 17, 2020
@samuelfahrngruber
Copy link
Contributor

When trying to reproduce this reliably, I found out that this happens more frequently, when there are so few filter items displayed after filtering by text, that the scrolling bar disappears.

e.g. This works:

grafik

This doesn't:

grafik

Also it seems that the issue happened after #1585, as commenting out this._writeInputValue(''); solved the problem in the barista demo app for me.

@lukasholzer lukasholzer added the filter-field Temporary label for filter field issues label Sep 22, 2020
@samuelfahrngruber samuelfahrngruber mentioned this issue Sep 22, 2020
Merged
samuelfahrngruber added a commit to samuelfahrngruber/barista that referenced this issue Sep 23, 2020
@samuelfahrngruber
fix(filter-field): Reverts a commit that introduced a bug when select…
af84250 
…ing suggestion values.

Fixes dynatrace-oss#1632

This reverts commit bb129d9.
lukasholzer pushed a commit that referenced this issue Sep 23, 2020
@samuelfahrngruber @lukasholzer
fix(filter-field): Reverts a commit that introduced a bug when select…
96cc4dc 
…ing suggestion values.

Fixes #1632

This reverts commit bb129d9.
lukasholzer pushed a commit that referenced this issue Sep 23, 2020
@samuelfahrngruber
fix(filter-field): Reverts a commit that introduced a bug when select…
4ad27e0 
…ing suggestion values.

Fixes #1632

This reverts commit bb129d9.
lukasholzer pushed a commit that referenced this issue Sep 23, 2020
@samuelfahrngruber
fix(filter-field): Reverts a commit that introduced a bug when select…
dd08844 
…ing suggestion values.

Fixes #1632

This reverts commit bb129d9.
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@samuelfahrngruber
fix(filter-field): Reverts a commit that introduced a bug when select…
0d1c3d7 
…ing suggestion values.

Fixes dynatrace-oss#1632

This reverts commit bb129d9.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A broken behaviour that was working previously filter-field Temporary label for filter field issues
Projects
None yet
Milestone
No milestone
3 participants
@lukasholzer @samuelfahrngruber @pawel-bugalski-dynatrace