Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
fix(filter-field): Fixes alignment of filter field tags.
Browse files Browse the repository at this point in the history
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes #573
  • Loading branch information
tomheller committed Feb 12, 2020
1 parent fa6d695 commit 9daa34e
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
@import '../../../core/src/style/variables';
@import '../../../style/font-mixins';

// from "* { Box-sizing: Border-box }
// FTW" @ https://www.paulirish.com/2012/box-sizing-border-box-ftw/
*,
*::before,
*::after {
box-sizing: inherit;
}

:host {
display: flex;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
text-rendering: optimizeLegibility;
box-sizing: border-box;
height: 24px;
border: 1px solid $gray-300;
border-radius: 3px;
background-color: $gray-130;
@include dt-main-font();
font-size: 12px;
color: $gray-500;
line-height: 22px;

&.dt-filter-field-tag-disabled {
border-color: $gray-200;
Expand Down
12 changes: 12 additions & 0 deletions components/filter-field/src/filter-field.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,20 @@

$dt-filter-field-inner-height: 30px;

// from "* { Box-sizing: Border-box }
// FTW" @ https://www.paulirish.com/2012/box-sizing-border-box-ftw/
*,
*::before,
*::after {
box-sizing: inherit;
}

:host {
display: block;
box-sizing: border-box;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
text-rendering: optimizeLegibility;
@include dt-form-control();

// We need to set overflow visible to prevent the outline
Expand Down

0 comments on commit 9daa34e

Please sign in to comment.