Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

FilterField changes its height by adding a filter #573

Closed
lukasholzer opened this issue Feb 10, 2020 · 0 comments · Fixed by #592
Closed

FilterField changes its height by adding a filter #573

lukasholzer opened this issue Feb 10, 2020 · 0 comments · Fixed by #592
Assignees
@tomheller
Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible

Comments

@lukasholzer
Copy link
Contributor

Bug Report

Expected Behavior

The filter Field should not change its height when a filter gets applied.

Current Behavior

When a filter gets toggled it starts to changes its height. The filter field without any filter is smaller than a filter field with height. This behaviour looks odd.

filter-field bug

Possible Solution

Increase the min-height.

Steps to Reproduce

  1. Create a filter field and toggle the filter programmatically via setting the filters array with one option.
  2. Then you see that the filter field is bouncing with the height.

Used Versions:

  • @dynatrace/barista-components: 5.1.1
@lukasholzer lukasholzer added P2 Issue that is important to resolve as soon as possible bug A broken behaviour that was working previously labels Feb 10, 2020
@lukasholzer lukasholzer added this to the Filter field milestone Feb 10, 2020
@ffriedl89 ffriedl89 added the good first issue Good for newcomers label Feb 11, 2020
@tomheller tomheller self-assigned this Feb 12, 2020
tomheller added a commit that referenced this issue Feb 12, 2020
@tomheller
fix(filter-field): Fixes alignment of filter field tags.
9daa34e 
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes #573
@tomheller tomheller mentioned this issue Feb 12, 2020
Merged
4 tasks
@tomheller tomheller added has-pr and removed good first issue Good for newcomers labels Feb 12, 2020
ffriedl89 pushed a commit that referenced this issue Feb 13, 2020
@tomheller @ffriedl89
fix(filter-field): Fixes alignment of filter field tags.
9817f6b 
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes #573
github-actions bot pushed a commit that referenced this issue Feb 13, 2020
@tomheller @ffriedl89
fix(filter-field): Fixes alignment of filter field tags.
f720005 
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes #573
github-actions bot pushed a commit that referenced this issue Feb 13, 2020
@tomheller @ffriedl89
fix(filter-field): Fixes alignment of filter field tags.
0034c09 
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes #573
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@tomheller
fix(filter-field): Fixes alignment of filter field tags.
4fc35fb 
Wrongfully assumed font-smoothing optimization and box-sizing
definitions. Line heights have changed again.

Fixes dynatrace-oss#573
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomheller tomheller

Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(filter-field): Fixes alignment of filter field tags. dynatrace-oss/barista
3 participants
@ffriedl89 @tomheller @lukasholzer