Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Filter field: Range stays open when clicking back into the filter field input and deleting the current filter #178

Closed
thomaspink opened this issue Nov 21, 2019 · 1 comment · Fixed by #854
Closed

Filter field: Range stays open when clicking back into the filter field input and deleting the current filter #178

thomaspink opened this issue Nov 21, 2019 · 1 comment · Fixed by #854
Assignees
@tomheller
Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible

Comments

@thomaspink
Copy link
Contributor

thomaspink commented Nov 21, 2019 •
edited
Loading

  1. Open a range filter
  2. Click away
  3. Focus filter field again (by clicking into the input field)
  4. Delete the current filter (backspace)

Filter field should be closed.
@thomaspink thomaspink added P2 Issue that is important to resolve as soon as possible bug A broken behaviour that was working previously labels Nov 21, 2019
@thomaspink thomaspink added this to the Filter field milestone Nov 21, 2019
@ffriedl89
Copy link
Collaborator

@thomaspink Is this still relevant?

@github-actions github-actions bot added the no-issue-activity Issue is stale for more than 30 days label Mar 2, 2020
@ffriedl89 ffriedl89 removed the no-issue-activity Issue is stale for more than 30 days label Mar 3, 2020
@dynatrace-oss dynatrace-oss deleted a comment from github-actions bot Apr 9, 2020
@tomheller tomheller self-assigned this Apr 9, 2020
tomheller added a commit that referenced this issue Apr 9, 2020
@tomheller
fix(filter-field): Fixes a bug where the range overlay was not closed.
8e6db97 
Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178
@tomheller tomheller mentioned this issue Apr 9, 2020
Merged
4 tasks
lukasholzer pushed a commit that referenced this issue Apr 14, 2020
@tomheller @lukasholzer
fix(filter-field): Fixes a bug where the range overlay was not closed.
d874b39 
Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178
github-actions bot pushed a commit that referenced this issue Apr 14, 2020
@tomheller @lukasholzer
fix(filter-field): Fixes a bug where the range overlay was not closed.
53aaeb0 
Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178
github-actions bot pushed a commit that referenced this issue Apr 14, 2020
@tomheller @lukasholzer
fix(filter-field): Fixes a bug where the range overlay was not closed.
6b594d8 
Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@tomheller
fix(filter-field): Fixes a bug where the range overlay was not closed.
1fe4a0d 
Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes dynatrace-oss#178
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomheller tomheller

Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(filter-field): Fixes a bug where the range overlay was not closed. dynatrace-oss/barista
3 participants
@thomaspink @ffriedl89 @tomheller