Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(filter-field): Fixes a bug where the range overlay was not closed. #854

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

tomheller
Copy link
Collaborator

Pull Request

Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178

Type of PR

Bugfix

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Fixes a bug where the range overlay was not closed when an autocomplete should have been shown.
When the autocomplete should be shown, we have added a check if a range is open, and if one is open
we close the range.

Fixes #178
@tomheller tomheller requested a review from ffriedl89 April 9, 2020 12:16
@tomheller tomheller self-assigned this Apr 9, 2020
@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Apr 9, 2020

Deploy preview for website ready!

Built with commit dfd86de

https://browser-o0xja9x8l.now.sh

@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Apr 14, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Apr 14, 2020
@lukasholzer lukasholzer merged commit d874b39 into master Apr 14, 2020
@lukasholzer lukasholzer deleted the fix/filterfield-range-stays-open branch April 14, 2020 06:54
@github-actions
Copy link

The auto cherry picker succeeded.Cherry picked to minor branch 6.x. New head is now 53aaeb0
Cherry picked to patch branch 6.2.x. New head is now 6b594d8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter field: Range stays open when clicking back into the filter field input and deleting the current filter
3 participants