Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ivy: Remove Renderer2 occurrences #518

Closed
thomaspink opened this issue Feb 3, 2020 · 1 comment · Fixed by #542
Closed

Ivy: Remove Renderer2 occurrences #518

thomaspink opened this issue Feb 3, 2020 · 1 comment · Fixed by #542
Labels
good first issue Good for newcomers P2 Issue that is important to resolve as soon as possible
Milestone

Comments

@thomaspink
Copy link
Contributor

For better compatibility with future renderer we should remove the occurrences or Renderer2.

Instead, let's use the injected document and add additional document or platform checks.

@thomaspink thomaspink added good first issue Good for newcomers P2 Issue that is important to resolve as soon as possible labels Feb 3, 2020
@thomaspink thomaspink added this to the Ivy milestone Feb 3, 2020
@lukasholzer
Copy link
Contributor

Is the usage of the Renderer deprecated in general?

thomaspink added a commit that referenced this issue Feb 4, 2020
Closes #518

BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
thomaspink added a commit that referenced this issue Feb 6, 2020
Closes #518

BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
thomaspink added a commit that referenced this issue Feb 6, 2020
Closes #518

BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
thomaspink added a commit that referenced this issue Feb 7, 2020
Closes #518

BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers P2 Issue that is important to resolve as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants