-
Notifications
You must be signed in to change notification settings - Fork 78
feat: Removes Renderer2 to be compatible with ivy. #542
Conversation
Deploy preview for website ready! Built with commit 4f56231 |
@@ -693,7 +692,7 @@ class TestApp { | |||
{ col1: 'test 1', col2: 'test 2', col3: 'test 3' }, | |||
]; | |||
|
|||
constructor(public _renderer: Renderer2) {} | |||
constructor() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Can be removed
a3bfcfd
ebe678f
to
a36b48f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but there are some conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code owner file LGTM
7c7667a
a36b48f
to
7c7667a
Compare
Closes #518 BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
BREAKING CHANGE: Core platform utils changed to be internal.
7c7667a
to
ec89670
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
Removes Renderer2 to be compatible with ivy.
Closes #518
BREAKING CHANGES:
Type of PR
Breaking change (fix or change that would cause existing functionality to not work as expected)
Checklist