This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
feat: Removes Renderer2 to be compatible with ivy. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for website ready! Built with commit 4f56231 |
tomheller
previously approved these changes
Feb 4, 2020
ffriedl89
previously approved these changes
Feb 5, 2020
| @@ -693,7 +692,7 @@ class TestApp { | |||
| { col1: 'test 1', col2: 'test 2', col3: 'test 3' }, | |||
| ]; | |||
|
|
|||
| constructor(public _renderer: Renderer2) {} | |||
| constructor() {} | |||
lukasholzer
previously approved these changes
Feb 5, 2020
lara-aigmueller
previously approved these changes
Feb 5, 2020
thomaspink
dismissed stale reviews from lara-aigmueller, lukasholzer, ffriedl89, and tomheller
via
a3bfcfd
thomaspink
requested review from
NinaKammerlander and
rowa-audil
as code owners
thomaspink
force-pushed
the
ivy-remove-renderer2
branch
from
ebe678f
to
a36b48f
Compare
thomaspink
requested review from
ffriedl89,
tomheller,
lara-aigmueller and
lukasholzer
lara-aigmueller
previously approved these changes
Feb 5, 2020
tomheller
previously approved these changes
Feb 5, 2020
NinaKammerlander
previously approved these changes
Feb 6, 2020
thomaspink
dismissed stale reviews from NinaKammerlander, rowa-audil, tomheller, and lara-aigmueller
via
7c7667a
thomaspink
force-pushed
the
ivy-remove-renderer2
branch
from
a36b48f
to
7c7667a
Compare
rowa-audil
previously approved these changes
Feb 6, 2020
Closes #518 BREAKING CHANGE: Components that are using the outdated Renderer2, which is removed in this commit, do this by injecting it via DI in their constructor. When removing the renderer constructor param the api changes which leads to a breaking change.
BREAKING CHANGE: Core platform utils changed to be internal.
thomaspink
force-pushed
the
ivy-remove-renderer2
branch
from
7c7667a
to
ec89670
Compare
thomaspink
requested review from
tomheller,
lara-aigmueller,
NinaKammerlander and
rowa-audil
and removed request for
tomheller
|
Kudos, SonarCloud Quality Gate passed!
|
lara-aigmueller
approved these changes
Feb 6, 2020
rowa-audil
approved these changes
Feb 6, 2020
NinaKammerlander
approved these changes
Feb 6, 2020
tomheller
approved these changes
Feb 6, 2020
github-actions
bot
added
the
target: major
ffriedl89
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Removes Renderer2 to be compatible with ivy.
Closes #518
BREAKING CHANGES:
Type of PR
Breaking change (fix or change that would cause existing functionality to not work as expected)
Checklist