This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix a11y chart tests #526

Closed

lukasholzer opened this issue Feb 4, 2020 · 1 comment · Fixed by #563

Assignees

Labels

Contributor

lukasholzer commented Feb 4, 2020 •

edited

Loading

Bug Report

Expected Behavior

The a11y tests should pass with our configuration.

Current Behavior

the blacklisted examples don't pass.

/** Blacklisted default examples */
const BLACKLIST = [
  'chart-selection-area-default-example',
  'chart-stream-example',
  'chart-loading-example',
];

Steps to Reproduce

Go to the apps/demos/src/barista-examples.a11y.ts a11y tests file and uncomment the blacklist.
Then run ng run demos:a11y --configuration=watch

Use --configurartion=ci to execute it like on the ci

Detailed Description

 ✖ chart-loading-example

   1) AssertionError: 1 violations found:
      1) ARIA attributes must conform to valid names
          "dt-loading-spinner"
      : expected false to be truthy

 ✖ chart-selection-area-default-example

   1) AssertionError: 1 violations found:
      1) ARIA attributes must conform to valid names
          "dt-chart-range"
      	"dt-chart-timestamp"
      : expected false to be truthy

 ✖ chart-stream-example

   1) AssertionError: 1 violations found:
      1) ARIA attributes must conform to valid names
          "dt-loading-spinner"
      : expected false to be truthy
```1

The text was updated successfully, but these errors were encountered:

lukasholzer added good first issue help wanted bug labels

lukasholzer added the P3 label

Collaborator

tomheller commented Feb 6, 2020

This one depends on #524 to be merged.

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

02d0dbf

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. ONly known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added the has-pr label

tomheller mentioned this issue

Fix/aria label conflicts #563

Merged

4 tasks

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

8fb15ff

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. ONly known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

c3d9985

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. ONly known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

4fc05f6

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added a commit that referenced this issue


          fix(consumption): Fixed the consumption-icon role to be set

e077bab

correctly.

Fixes an accessibility issue, where the consumption icon set an
`aria-role` attribute to its host, but the accepted attribute is `role`.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

5c8dafe

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

450c7ec

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          fix(tag-list): Fixes an issue where the aria-label was not applied

96f4a0d

correctly.

Fixed the binding of the aria label to the host and added aria-labels to
all the examples.

Fixes #526

tomheller added a commit that referenced this issue


          fix(toggle-button-group): Fixes an issue with wrong aria-pressed

ead204b

attribute on radio roles.

The `toggle-button-group-item` wrongfully applied a `aria-pressed`
attribute, but the allowed one within an radio-group is `aria-checked`.

Fixes #526

tomheller added a commit that referenced this issue


          fix(tag-list): Fixes an issue where the aria-label was not applied

65ea1b5

correctly.

Fixed the binding of the aria label to the host and added aria-labels to
all the examples.

Fixes #526

tomheller added a commit that referenced this issue


          fix(toggle-button-group): Fixes an issue with wrong aria-pressed

b71a05a

attribute on radio roles.

The `toggle-button-group-item` wrongfully applied a `aria-pressed`
attribute, but the allowed one within an radio-group is `aria-checked`.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

3dbb615

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

827726a

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

95cc39f

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

02eb540

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

ce946c1

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

f46b987

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

f4815fb

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added a commit that referenced this issue


          fix(consumption): Fixed the consumption-icon role to be set

correctly.

Fixes an accessibility issue, where the consumption icon set an
`aria-role` attribute to its host, but the accepted attribute is `role`.

Fixes #526

tomheller added a commit that referenced this issue


          fix(tag-list): Fixes an issue where the aria-label was not applied

1b0e936

correctly.

Fixed the binding of the aria label to the host and added aria-labels to
all the examples.

Fixes #526

tomheller added a commit that referenced this issue


          fix(toggle-button-group): Fixes an issue with wrong aria-pressed

ff6061d

attribute on radio roles.

The `toggle-button-group-item` wrongfully applied a `aria-pressed`
attribute, but the allowed one within an radio-group is `aria-checked`.

Fixes #526

tomheller removed the help wanted label

tomheller self-assigned this

tomheller added a commit that referenced this issue


          fix(consumption): Fixed the consumption-icon role to be set

03e5042

correctly.

Fixes an accessibility issue, where the consumption icon set an
`aria-role` attribute to its host, but the accepted attribute is `role`.

Fixes #526

tomheller added a commit that referenced this issue


          fix(tag-list): Fixes an issue where the aria-label was not applied

cde0718

correctly.

Fixed the binding of the aria label to the host and added aria-labels to
all the examples.

Fixes #526

tomheller added a commit that referenced this issue


          fix(toggle-button-group): Fixes an issue with wrong aria-pressed

f63a8ba

attribute on radio roles.

The `toggle-button-group-item` wrongfully applied a `aria-pressed`
attribute, but the allowed one within an radio-group is `aria-checked`.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

5e510d5

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

4db82f0

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

4a4bc80

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          fix(chart): Fixes an issue with aria label name clashes for a11y.

71e183a

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller added a commit that referenced this issue


          fix(consumption): Fixed the consumption-icon role to be set

a49f3ee

correctly.

Fixes an accessibility issue, where the consumption icon set an
`aria-role` attribute to its host, but the accepted attribute is `role`.

Fixes #526

tomheller added a commit that referenced this issue


          fix(tag-list): Fixes an issue where the aria-label was not applied

c564260

correctly.

Fixed the binding of the aria label to the host and added aria-labels to
all the examples.

Fixes #526

tomheller added a commit that referenced this issue


          fix(toggle-button-group): Fixes an issue with wrong aria-pressed

09daf44

attribute on radio roles.

The `toggle-button-group-item` wrongfully applied a `aria-pressed`
attribute, but the allowed one within an radio-group is `aria-checked`.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

a7c4431

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

3e72c0c

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

5cbad8d

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

30e9119

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

369e28b

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

6be163e

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          chore(empty-state): Fixed aria-level missing on empty state header

0c16245

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          chore(cta-card): Fixes missing img alt text for a11y in example.

ed2d85e

Fixes #526

tomheller added a commit that referenced this issue


          chore(table): Fixes a11y issues in the table examples.

d574e24

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          fix(empty-state): Fixed aria-level missing on empty state header

aac7bae

elements in the example.

Fixes #526

tomheller added a commit that referenced this issue


          fix(cta-card): Fixes missing img alt text for a11y in example.

ad97ab9

Fixes #526

tomheller added a commit that referenced this issue


          fix(table): Fixes a11y issues in the table examples.

9b04239

The empty state within the table needs to have a valid role, to be
present in the table. As an empty table without `row` or `rowgroup`
roled elements is invalid.

Fixes #526

tomheller added a commit that referenced this issue


          fix(chart, inline-editor, pagination, context-dialog, consumption, to…

b100df2

…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y.

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

tomheller closed this as completed in #563

tomheller added a commit that referenced this issue


          fix(chart, inline-editor, pagination, context-dialog, consumption, to…

2f82aed

…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y.

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

github-actions bot pushed a commit that referenced this issue


          fix(chart, inline-editor, pagination, context-dialog, consumption, to…

73532da

…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y.

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes #526
Fixes #79

yngrdyn pushed a commit to yngrdyn/barista that referenced this issue


          fix(chart, inline-editor, pagination, context-dialog, consumption, to…

af4a592

…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y.

Specific inputs like `aria-label-button-close` are not allowed based on
the aria specification. Only known aria attributes are allowed to be
used. We have renamed the inputs in question to their camelcased
version, but kept the old ones for compatibility for now.
With version 7.0. we sould remove the kebap-cased inputs.

Fixes dynatrace-oss#526
Fixes dynatrace-oss#79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.