This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
A11y: Aria labels input refactoring #79
Comments
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. ONly known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. ONly known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. ONly known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 6, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 7, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 7, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 7, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. The role `navigation` is not allowed on ol/ul elements as it would highjack the natural accessibility of the list. We have removed the navigation role from the pagination root list and added it to the host element. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 7, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. The role `navigation` is not allowed on ol/ul elements as it would highjack the natural accessibility of the list. We have removed the navigation role from the pagination root list and added it to the host element. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. The role `navigation` is not allowed on ol/ul elements as it would highjack the natural accessibility of the list. We have removed the navigation role from the pagination root list and added it to the host element. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 12, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
…11y. Specific inputs like `aria-label-save` and `aria-label-save` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
Specific inputs like `aria-label-next` and `aria-label-current` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. The role `navigation` is not allowed on ol/ul elements as it would highjack the natural accessibility of the list. We have removed the navigation role from the pagination root list and added it to the host element. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
…a11y. Specific inputs like `aria-label-close-button` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y. Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
tomheller
added a commit
that referenced
this issue
Feb 13, 2020
…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y. Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
github-actions bot
pushed a commit
that referenced
this issue
Feb 13, 2020
…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y. Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes #526 Fixes #79
yngrdyn
pushed a commit
to yngrdyn/barista
that referenced
this issue
Nov 9, 2020
…ggle-button-group, tag-list, empty-state, cta-card, table, filter-field): Fixes an issue with aria label name clashes for a11y. Specific inputs like `aria-label-button-close` are not allowed based on the aria specification. Only known aria attributes are allowed to be used. We have renamed the inputs in question to their camelcased version, but kept the old ones for compatibility for now. With version 7.0. we sould remove the kebap-cased inputs. Fixes dynatrace-oss#526 Fixes dynatrace-oss#79
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We need to deprecate all the aria labels like
aria-label-closethat are violating our accessibility tests and rename the inputs to ariaLabelClose so when they are bound they are in the template.The text was updated successfully, but these errors were encountered: