This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
A11y: Expandables (section, panel, trigger) lack aria properties #788
Comments
ffriedl89
added
bug
A broken behaviour that was working previously
good first issue
Good for newcomers
help wanted
Extra attention is needed
P2
Issue that is important to resolve as soon as possible
labels
Mar 24, 2020
tomheller
removed
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Apr 2, 2020
tomheller
added a commit
that referenced
this issue
Apr 2, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
4 tasks
tomheller
added a commit
that referenced
this issue
Apr 2, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
tomheller
added a commit
that referenced
this issue
Apr 6, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
tomheller
added a commit
that referenced
this issue
Apr 7, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
github-actions bot
pushed a commit
that referenced
this issue
Apr 7, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
github-actions bot
pushed a commit
that referenced
this issue
Apr 7, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
yngrdyn
pushed a commit
to yngrdyn/barista
that referenced
this issue
Nov 9, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes dynatrace-oss#788
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
The expandable trigger lacks the correct aria attributes.
Expected Behavior
Expandable trigger:
The trigger should have the
aria-controls
property set to the id of the expandable panel it controls.The trigger should also have the
aria-expanded
set depending on the expand state of the panel.This is also expected to behave correctly in the expandable panel, but this should be covered since we use the trigger internally.
for references and a11y best practices please see https://www.w3.org/TR/wai-aria-practices-1.1/#accordion
https://www.w3.org/TR/wai-aria-1.1/#aria-expanded
Current Behavior
Currently there is no aria-expanded or aria-controls property set on the trigger.
Possible Solution
Add those properties to the host metadata. We might also have to introduce an id input for the expandable panel with a generated id defaulted similar to the id we have in the radio.ts for example to be
The text was updated successfully, but these errors were encountered: