This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Expandables Added aria-controls and aria-expanded #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for website ready! Built with commit f97ed92 |
tomheller
force-pushed
the
feat/add-aria-to-expanded
branch
from
5a82b95
to
3c70afa
Compare
ffriedl89
suggested changes
Apr 3, 2020
…a-controls and aria-expanded. Fixed an issue where the correct aria attributes where not present on accordion like elements like expandable-section, expandable-text and expandable-panel. Fixes #788
tomheller
force-pushed
the
feat/add-aria-to-expanded
branch
from
3c70afa
to
6d4f590
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lukasholzer
approved these changes
Apr 6, 2020
| } | ||
|
|
||
| /** Mixin to augment a directive with a `id` property. */ | ||
| export function mixinId<T extends Constructor<{}>>( |
ffriedl89
approved these changes
Apr 7, 2020
github-actions
bot
added
target: minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixed an issue where the correct aria attributes where not present on accordion like elements like
expandable-section, expandable-text and expandable-panel.
Fixes #788
Type of PR
Bugfix
Checklist