Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Formfield]: Focus management and outlines are weird #999

Closed
tomheller opened this issue May 13, 2020 · 0 comments · Fixed by #1294
Closed

[Formfield]: Focus management and outlines are weird #999

tomheller opened this issue May 13, 2020 · 0 comments · Fixed by #1294
Labels
bug A broken behaviour that was working previously good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tomheller
Copy link
Collaborator

Bug Report

The focus management of the form field, especially when used with infix and/or suffix inlays looks a little weird:
image

Expected Behavior

I would expect that the input field within the form field would not get an extra outline around it.

Current Behavior

See the image above

Possible Solution

Adjust the focusmonitor if the input is used within a formfield.

Steps to Reproduce

  1. Navigate to https://barista.dynatrace.com/components/form-field
  2. Scroll to the Prefix and suffix example
  3. Focus the input within the example by clicking into it.

Used Versions:

  • @dynatrace/barista-components: 6.5.0
@tomheller tomheller added the bug A broken behaviour that was working previously label May 13, 2020
@thomaspink thomaspink added the good first issue Good for newcomers label May 19, 2020
@tomheller tomheller added the help wanted Extra attention is needed label May 26, 2020
bartoszbobin added a commit to bartoszbobin/barista that referenced this issue Jul 15, 2020
@bartoszbobin
style(input): Fixes extra outlines when places inside form-field
908a5e2 
Fixes dynatrace-oss#999

- add new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
@bartoszbobin bartoszbobin mentioned this issue Jul 15, 2020
Closed
2 tasks
bartoszbobin added a commit to bartoszbobin/barista that referenced this issue Jul 15, 2020
@bartoszbobin
style(input): Fixes extra outlines when places inside form-field
312efc4 
Fixes dynatrace-oss#999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
@bartoszbobin bartoszbobin mentioned this issue Jul 15, 2020
Merged
2 tasks
bartoszbobin added a commit to bartoszbobin/barista that referenced this issue Jul 15, 2020
@bartoszbobin
style(input): Fixes extra outlines when places inside form-field
a319601 
Fixes dynatrace-oss#999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
bartoszbobin added a commit to bartoszbobin/barista that referenced this issue Jul 16, 2020
@bartoszbobin
fix(input): Fixes extra outlines when places inside form-field
920352a 
Fixes dynatrace-oss#999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
ffriedl89 pushed a commit that referenced this issue Jul 20, 2020
@bartoszbobin @ffriedl89
fix(input): Fixes extra outlines when places inside form-field
cde214f 
Fixes #999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
ffriedl89 pushed a commit that referenced this issue Jul 20, 2020
@bartoszbobin @ffriedl89
fix(input): Fixes extra outlines when places inside form-field
f0df782 
Fixes #999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
ffriedl89 pushed a commit that referenced this issue Jul 20, 2020
@bartoszbobin @ffriedl89
fix(input): Fixes extra outlines when places inside form-field
a54f4f9 
Fixes #999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@bartoszbobin
fix(input): Fixes extra outlines when places inside form-field
a69bc56 
Fixes dynatrace-oss#999

- added new example in dev app

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A broken behaviour that was working previously good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@thomaspink @tomheller