style(input): Fixes extra outlines when places inside form-field #1294
Conversation
bartoszbobin
requested review from
ffriedl89,
lukasholzer,
thomaspink and
tomheller
as code owners
There was a problem hiding this comment.
Thx a lot @bartoszbobin you are on 🔥 . So many contributions coming in.
We really appreciate it.
| @@ -56,6 +56,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| .dt-focused { | |||
There was a problem hiding this comment.
This might be a bit dangerous, I'd suggest adding a .dt-form-field selector here as well.
| .dt-focused { | |
| .dt-form-field.dt-focused { |
There was a problem hiding this comment.
Wasn't sure if dtInput should be aware of dt-form-field.
Maybe this should be placed in dt-form-field styles?
What do you think @ffriedl89 ?
There was a problem hiding this comment.
Yeah i agree, it makes sense to include those styles in the form-field.scss instead.
bartoszbobin
force-pushed
the
formfield-too-many-outlines
branch
from
312efc4
to
a319601
Compare
There was a problem hiding this comment.
Looks good to me. Thank you @bartoszbobin 💯 for all these contributions. You are on 🔥
|
Wow so many contributions. Holy moly. Looks good to me! Just on minor thing, please change the type of your commit message from
|
Fixes dynatrace-oss#999 - added new example in dev app Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
bartoszbobin
force-pushed
the
formfield-too-many-outlines
branch
from
a319601
to
920352a
Compare
tomheller
added
pr: needs-cherry-pick
|
cherry-pick done |
Bugfix (non-breaking change which fixes an issue)
Fixes #999
Before fix:
https://barista.dynatrace.com/components/form-field#prefix-and-suffix
After fix:
Checklist