SHADERC_STATIC="./here/" #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are here because your windows or macos builds are breaking, I apologize. The changes were not developed on these platforms. You will have to research older versions of the crate to establish whether they were in a "just works" state and if not, research your relevant platform options and make it work. This commit implements several new build behaviors: - Building libshaderc from source is now fallback behavior on Linux - Linux will check "/usr/lib/" for libraries by default - SPIRV and glslang libraries _may_ be picked up correctly if they exist in the same location as libshaderc, but funky combinations could break - Specification of a static library via SHADERC_STATIC, SHADERC_LIB_DIR, or SHADERC_LIB_PATH instead of the hacky --no-default-options - tests will build correctly when using hacky --no-default-options paths (stdc was not being included)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are here because your windows or macos builds are breaking, I apologize. The changes were not developed on these platforms. You will have to research older versions of the crate to establish whether they were in a "just works" state and if not, research your relevant platform options and make it work.
This commit implements several new build behaviors: