Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate button "I can't give feedback" #1675

Closed
janno42 opened this issue Nov 29, 2021 · 0 comments · Fixed by #1706
Closed

Relocate button "I can't give feedback" #1675

janno42 opened this issue Nov 29, 2021 · 0 comments · Fixed by #1706
Assignees
@Kakadus
Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Small This issue should require only small changes.

Comments

@janno42
Copy link
Member

janno42 commented Nov 29, 2021

The buttons "I can't give feedback about this contributor" in the student voting form should be placed inside the respective cards' bodies. They should stay right-aligned at the top, alongside the heading text.

The buttons must be tab-selectable when the respective cards are open and the buttons are not disabled (the buttons are disabled when they are pressed and get enabled again when any voting option is selected).
@janno42 janno42 added [C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Small This issue should require only small changes. labels Nov 29, 2021
@Kakadus Kakadus mentioned this issue Feb 14, 2022
Merged
janno42 pushed a commit that referenced this issue May 13, 2022
@Kakadus @niklasmohrin
Fix #1675: Relocate button "I can't give feedback" (#1706)
a3ca8bc 
* relocate-button

* make tabbing work correctly

* fix js pitfall

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>

* move first entry in loop

* first reformat

* extract hasTabbingTarget

* Update student-vote.ts
Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
Kakadus added a commit to Kakadus/EvaP that referenced this issue Jul 25, 2022
@Kakadus @niklasmohrin
Fix e-valuation#1675: Relocate button "I can't give feedback" (e-valu…
c289a7c 
…ation#1706)

* relocate-button

* make tabbing work correctly

* fix js pitfall

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>

* move first entry in loop

* first reformat

* extract hasTabbingTarget

* Update student-vote.ts
Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kakadus Kakadus

Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Small This issue should require only small changes.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1675: Relocate button "I can't give feedback" Kakadus/EvaP
2 participants
@janno42 @Kakadus