-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1675: Relocate button "I can't give feedback" #1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button location and functionality are perfect. unfortunately, the keyboard navigation doesn't work anymore, tabbing over the repositioned button is currently not possible. @niklasmohrin can probably help you with that :)
Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, behavior seems fine. Thanks!
@janno42 when using the keyboard to select "I can't give feedback [...]", the keyboard focus stays on this button while the card collapses. So, to advance, users have to press "tab" afterwards. Until they do, they will not see which item has keyboard focus. My first intuition was that it should automatically forward to the next element, but the more I think about it, the less I think I'd like it. What do you think?
For me, both solutions are fine. Because keeping it as it is now produces less overhead, I'd say it can stay as it is :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Meets requirements
✔️ UI functionality checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(blocking for my comment earlier)
@Kakadus, do you want to continue working on this PR? There shouldn't be much left to do here. |
I am refactoring it now... |
Thanks! You could have a look at your git settings, you are committing with three different users, two having invalid email addresses, one of which ends in "guthub.com" :) |
…ation#1706) * relocate-button * make tabbing work correctly * fix js pitfall Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de> * move first entry in loop * first reformat * extract hasTabbingTarget * Update student-vote.ts Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
Fixes #1675