-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support live server tests with Selenium #2077
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, I feel that there are some parts that could be cleaned up or need some more explanation otherwise:
d1316bf
to
a0bb516
Compare
Manager group was not present, but only if all tests are run. We found that django will first run Link dump if we try to debug this again:
We concluded that we want to migrate an empty database, dump it, and use that dump as a |
a0bb516
to
fd65ecd
Compare
cad398e
to
bb6a85c
Compare
@Kakadus @niklasmohrin @richardebeling Finally, the last test has been migrated and I'm ready for a final review. 🥳 |
6f8cb5d
to
88d3f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet fully reviewed, will have to look through most of the ported tests still, but generally this is looking very nice. Thanks!
Getting chromium or firefox should be a lot easier now that we have nix, we can work something out together some time if you want :) |
d182ee9
to
a88cdfa
Compare
Heey, there is a green check now! 🎉 @hansegucker do you want to take over and resolve the open threads? If not, I can also finish this : ) Things I fixed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I especially like the changes to package.json and package-lock.json.
Haven't re-checked yet whether all ported tests assert the same things as the old tests, will need to re-do that in a final review.
66615d3
to
9e7c0f1
Compare
3db514f
to
6c19036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! After ensuring that I follow the steps from CI, they also passed locally :)
d3c81f2
to
5fca752
Compare
e92336f
to
8521292
Compare
move enter staff mode to contextmanager
8521292
to
4c66f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kakadus you re-requested review but some of the older review discussion points are still open. I'm generally fine with the code once these are resolved.
7824025
to
3bacbb4
Compare
Close #1854