Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: track github actions with dependabot #2168

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Apr 22, 2024

Just saw some warnings in the latest ci runs, github is deprecating another node version. I never actually saw any practical incompatibilities of actions, so I told dependabot to group all ci PRs for less noise.

.github/dependabot.yml Outdated Show resolved Hide resolved
@richardebeling
Copy link
Member

richardebeling commented Apr 22, 2024

I'm a bit confused, I don't see a deprecation warning (I checked out the output of the "Compile SCSS / Setup nodejs" step).
Our workflow definition file in .github/setup_nodejs/action.yml doesn't seem to specify a node version. Where exactly can I find the warning and what version specification are we talking about?

In general, I'm fine with just always running on the latest stable node version. After #2077, we're basically only using node for scss and typescript, both are big enough for that to work I guess.

@Kakadus
Copy link
Collaborator Author

Kakadus commented Apr 29, 2024

I'm a bit confused, I don't see a deprecation warning (I checked out the output of the "Compile SCSS / Setup nodejs" step). Our workflow definition file in .github/setup_nodejs/action.yml doesn't seem to specify a node version. Where exactly can I find the warning and what version specification are we talking about?

The warnings I talked about are here if you scoll down. It is related to the node version used to execute the ci step itself. We currently use actions/checkout@v3, actions/setup-python@v4, actions/setup-node@v3 and actions/upload-artifact@3 which are all "deprecated" by github

In general, I'm fine with just always running on the latest stable node version. After #2077, we're basically only using node for scss and typescript, both are big enough for that to work I guess.

The warnings are not related to the node version we use (e.g. we could still use an old node version with the new action versions)

Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, didn't see those. The changes are fine with me then

@Kakadus Kakadus merged commit a30a861 into e-valuation:main Apr 29, 2024
10 checks passed
@Kakadus Kakadus deleted the actions-dependabot branch April 29, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants