Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15020] Typo fix and a change to use CMake instead of make. #376

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[15020] Typo fix and a change to use CMake instead of make. #376

merged 2 commits into from
Jun 30, 2022

Conversation

MRicoIE2CS
Copy link
Contributor

Typo fix and a change to use CMake instead of make.
Signed-off-by: Mikel Rico mikelrico@eprosima.com

@MRicoIE2CS
Refs#15020: Typo fix and a change to use CMake instead of make.
4ddf642 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
JLBuenoLopez
JLBuenoLopez previously approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

@JLBuenoLopez JLBuenoLopez added this to the 2.7.0 milestone Jun 30, 2022
@MRicoIE2CS
Refs#15020: Correction for CI test.
6397351 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
JLBuenoLopez
JLBuenoLopez approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JLBuenoLopez JLBuenoLopez merged commit a91a3ce into master Jun 30, 2022
@JLBuenoLopez JLBuenoLopez deleted the hotfix/typoFixes branch June 30, 2022 09:03
@EduPonz EduPonz changed the title #[15020]: Typo fix and a change to use CMake instead of make. [15020]: Typo fix and a change to use CMake instead of make. Jun 30, 2022
@EduPonz EduPonz changed the title [15020]: Typo fix and a change to use CMake instead of make. [15020] Typo fix and a change to use CMake instead of make. Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MRicoIE2CS @JLBuenoLopez