[17555] XML section improvements #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…iltin documentation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…ist wrong information and include missing snippets Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
8 tasks
JLBuenoLopez
suggested changes
Mar 15, 2023
There was a problem hiding this comment.
I am missing the addition of every supported thing to the complete example. Also client_announcements is not included in the DomainParticipant::Builtin snippet. Every supported option must be shown in the specific snippet and also in the example snippet.
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…Discovey Server settings section Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…s data writer/reader topic Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
hotfix/update_xml_schema
branch
from
a60b461
to
142a139
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JLBuenoLopez
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test has passed locally.
clientAnnouncementPeriodis supported but was not included in the documentation.static_edp_xml_configis a list and not a string.discoveryServersListcorrections.topicwas already supported as profile in Fast DDS, so it must be documented as a profile (withprofile_nameandis_default_profileattributes)library_settingsis not supported as profile. Move it as dds child.participant>rtps>allocation>send_buffersis supported but was not included in the documentation.