Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17559] Update Fast DDS profiles schema with troubleshooting errors #3363

Merged
merged 10 commits into from
Mar 17, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 14, 2023

Validation test has passed locally.

Description

The XML schema has been updated to meet the following requirements:

  • topic was already supported as profile in Fast DDS, so it is also supported in the schema as a profile (with profile_name and is_default_profile attributes)
  • library_settings is not supported as profile. Move it as dds child.
  • participant > rtps > allocation > send_buffers is supported but was not included in the schema.

Also, missing elements has been added in the XML profile testing files.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [17555] XML section improvements Fast-DDS-docs#465 (PR)
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI doc-pending Issue or PR which is pending to be documented labels Mar 14, 2023
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…files

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…e in the schema

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…e in the XML files

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v2.10.0 milestone Mar 14, 2023
@JesusPoderoso JesusPoderoso removed the doc-pending Issue or PR which is pending to be documented label Mar 14, 2023
Copy link
Contributor

@MRicoIE2CS MRicoIE2CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question

resources/xsd/fastRTPS_profiles.xsd Outdated Show resolved Hide resolved
resources/xsd/fastRTPS_profiles.xsd Show resolved Hide resolved
resources/xsd/fastRTPS_profiles.xsd Show resolved Hide resolved
@MRicoIE2CS MRicoIE2CS added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI labels Mar 16, 2023
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…ttings' tag as standalone

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso

This comment was marked as resolved.

@JesusPoderoso

This comment was marked as resolved.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso

This comment was marked as resolved.

Copy link
Contributor

@MRicoIE2CS MRicoIE2CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor Author

@richiprosima Please test this

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 17, 2023
@MiguelCompany MiguelCompany merged commit affd8a0 into master Mar 17, 2023
@MiguelCompany MiguelCompany deleted the hotfix/update_xml_schema branch March 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants