Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20439] Authentication Handshake Properties documentation #681

Merged
merged 2 commits into from
Mar 1, 2024
Merged

[20439] Authentication Handshake Properties documentation #681

merged 2 commits into from
Mar 1, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Feb 22, 2024 •
edited by elianalf
Loading

This PR adds the documentation for configuring the Authentication Handshake behavior through the following properties:

  • max_handshake_requests
  • initial_handshake_resend_period
  • handshake_resend_period_gain

And also, fills the PropertyPolicy Security page by remembering the configurable properties of the different security plugins

We may backport this to 2.13.x 2.12.x 2.10.x and 2.6.x

@Mario-DL
Refs #20439: AuthenticationHandshakeProperties documentation
0005ae0 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL mentioned this pull request Feb 22, 2024
Merged
14 tasks
@Mario-DL Mario-DL added this to the v2.14.0 milestone Feb 22, 2024
@Mario-DL
Copy link
Member Author

@richiprosima please test docs

elianalf
elianalf suggested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@elianalf elianalf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is clear! It would be nice if there was a reference to the new page Security Plugin Settings at the end of the section 8. Security so it can be easly found

docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/security.rst Outdated Show resolved Hide resolved
@Mario-DL
Copy link
Member Author

Everything is clear! It would be nice if there was a reference to the new page Security Plugin Settings at the end of the section 8. Security so it can be easly found

Good one !

@Mario-DL Mario-DL force-pushed the feature/20439 branch 2 times, most recently from 5fa54ba to c4f71f6 Compare February 27, 2024 06:58
@Mario-DL
Refs #20439: Review suggestions
fe353e2 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test docs

@EduPonz EduPonz merged commit 557efa3 into master Mar 1, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/20439 branch March 1, 2024 06:52
@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Mar 1, 2024 •
edited
Loading

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 1, 2024
@Mario-DL @mergify
Authentication Handshake Properties documentation (#681)
a03c40c 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)
@mergify mergify bot mentioned this pull request Mar 1, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2024
@Mario-DL @mergify
Authentication Handshake Properties documentation (#681)
3a9ed77 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)
@mergify mergify bot mentioned this pull request Mar 1, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2024
@Mario-DL @mergify
Authentication Handshake Properties documentation (#681)
3437b21 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)
@mergify mergify bot mentioned this pull request Mar 1, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2024
@Mario-DL @mergify
Authentication Handshake Properties documentation (#681)
d9d2e5e 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)
@mergify mergify bot mentioned this pull request Mar 1, 2024
Merged
JesusPoderoso pushed a commit that referenced this pull request Mar 4, 2024
@mergify @Mario-DL
Authentication Handshake Properties documentation (#681) (#702)
44179ea 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Mar 11, 2024
@mergify @Mario-DL
Authentication Handshake Properties documentation (#681) (#704)
0c2f58f 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
elianalf pushed a commit that referenced this pull request Mar 13, 2024
@mergify @Mario-DL
Authentication Handshake Properties documentation (#681) (#703)
229b1a7 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Mario-DL added a commit that referenced this pull request Apr 16, 2024
@mergify @Mario-DL
Authentication Handshake Properties documentation (#681) (#705)
34b77a5 
* Refs #20439: AuthenticationHandshakeProperties documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Review suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 557efa3)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mario-DL @JesusPoderoso @elianalf @EduPonz