-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20439] Expose Authentication Handshake Properties #4435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mario-DL
force-pushed
the
feature/20439
branch
from
February 23, 2024 07:48
2cf6e9c
to
332df27
Compare
@richiprosima please test linux |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
force-pushed
the
feature/20439
branch
from
February 26, 2024 06:43
332df27
to
d07bd96
Compare
@richiprosima please test linux |
(Rebased on top of 31a83ca for avoiding |
@richiprosima please test discovery_server |
elianalf
suggested changes
Feb 26, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
force-pushed
the
feature/20439
branch
from
February 26, 2024 16:55
fa8ef4b
to
26edae5
Compare
@richiprosima please test linux test discovery_server |
… range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@richiprosima please test linux test discovery_server |
elianalf
approved these changes
Feb 28, 2024
elianalf
approved these changes
Feb 28, 2024
@richiprosima please test discovery-server test windows |
@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84)
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) # Conflicts: # src/cpp/rtps/security/SecurityManager.h # versions.md
Mario-DL
added a commit
that referenced
this pull request
Mar 6, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
added a commit
that referenced
this pull request
Mar 6, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Expose Authentication Handshake Properties (#4435) * Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20551: Fix test. Do not depend on the XML substituting feature Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 11, 2024
* Expose Authentication Handshake Properties (#4435) * Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20551: Fix test. Do not depend on the XML substituting feature Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
elianalf
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84)
EduPonz
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Expose Authentication Handshake Properties (#4435) * Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) * Solve conflicts Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the documentation for configuring the Authentication Handshake behavior through the following properties:
It also includes a simple
PropertyParser
for parsing properties asint
anddouble
.@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).<Related documentation PR: [20439] Authentication Handshake Properties documentation Fast-DDS-docs#681
Reviewer Checklist