Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21446] Fast DDS Monitor refactor: Fast DDS v3 compatibility #227

Merged
merged 5 commits into from
Sep 11, 2024
Merged

[21446] Fast DDS Monitor refactor: Fast DDS v3 compatibility #227

merged 5 commits into from
Sep 11, 2024

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Aug 1, 2024 •
edited by JesusPoderoso
Loading

Add minor changes for Monitor compilation with Fast DDS v3. Fast DDS Statistics Backend migration to Fast DDS v3 (eProsima/Fast-DDS-statistics-backend#239) required.

Related PRs

@Carlosespicur Carlosespicur mentioned this pull request Aug 27, 2024
Merged
JesusPoderoso
JesusPoderoso requested changes Aug 28, 2024
View reviewed changes
docs/rst/notes/notes.rst Show resolved Hide resolved
docs/rst/notes/previous_versions/v2.0.0.rst Show resolved Hide resolved
docs/rst/ros/galactic/galactic.rst Outdated Show resolved Hide resolved
@JesusPoderoso JesusPoderoso mentioned this pull request Aug 28, 2024
Merged
JesusPoderoso
JesusPoderoso previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI
Lets wait the backend PR to get merged to trigger it

@Carlosespicur Carlosespicur mentioned this pull request Sep 2, 2024
Merged
5 tasks
@Carlosespicur Carlosespicur force-pushed the feature/fastdds3-migration branch 4 times, most recently from ae94acd to ebb94b2 Compare September 6, 2024 12:07
@JesusPoderoso JesusPoderoso mentioned this pull request Sep 9, 2024
Merged
@Carlosespicur
Add minor changes for Monitor compilation using refactored fastdds_s…
a42578a 
…tatistics_backend

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Refs #21446: Add review changes
4f59538 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Refs #21446: Update docs dependencies
6e50270 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Refs #21446: Fix test.yml to add python dependencies
4e6edcf 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Refs #21446: Fix documentation tests
6770496 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
JesusPoderoso
JesusPoderoso approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI results should be considered from this PR

@JesusPoderoso JesusPoderoso removed the request for review from rsanchez15 September 10, 2024 14:32
@rsanchez15 rsanchez15 merged commit 48d90a1 into main Sep 11, 2024
6 of 8 checks passed
@rsanchez15 rsanchez15 deleted the feature/fastdds3-migration branch September 11, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carlosespicur @JesusPoderoso @rsanchez15