[21302] Fast DDS statistics backend migration to Fast DDS v3.0 #239

Carlosespicur · 2024-07-09T08:35:04Z

This PR allows to compile Fast DDS Statistics Backend with Fast DDS v3.0.0
Main Changes

Overload removed in init_monitor() for discovery servers. Initialising the monitor using a custom GUID is no longer supported.
Types regenerated using FastDDS v4.0.0
Old headers and guards changed
Changed fastrtps namespace to fastdds
Private classes (ReaderProxyData, WriterProxyData and ParticipantProxyData) changed to the new public ones
Discovery StatisticsParticipantListener callbacks updated
Refactored tests

Comments
Communication test does not work correctly: timeout error using low resources

Related PRS

[21446] Fast DDS Monitor refactor: Fast DDS v3 compatibility Fast-DDS-monitor#227

Dependant PRs

[21458] Add IDL format to topic entities #245

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

…cipantFactory mock class Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

test/dds/communication_old/CMakeLists.txt

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

JesusPoderoso

A couple of nits

colcon.meta

include/fastdds_statistics_backend/topic_types/monitorservice_typesPubSubTypes.h

src/cpp/subscriber/StatisticsParticipantListener.cpp

test/dds/communication/Monitor.cpp

test/dds/communication/Subscriber.cpp

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

JesusPoderoso

LGTM with green CI

JesusPoderoso · 2024-09-02T06:14:48Z

CI issues reflect existing uncrustify issues with nlohmann-json thirdparty, and a flaky test issue that will be addressed in future PRs.
This PR is ready to merge!

Carlosespicur had a problem deploying to codecov July 9, 2024 08:35 — with GitHub Actions Failure

Carlosespicur changed the title ~~Fast DDS statistics backend migration to Fast DDS 3~~ Fast DDS statistics backend migration to Fast DDS 3.0 Jul 9, 2024

Carlosespicur changed the title ~~Fast DDS statistics backend migration to Fast DDS 3.0~~ Fast DDS statistics backend migration to Fast DDS v3.0 Jul 9, 2024

Carlosespicur had a problem deploying to codecov July 9, 2024 09:52 — with GitHub Actions Failure

Carlosespicur had a problem deploying to codecov July 11, 2024 08:16 — with GitHub Actions Failure

rsanchez15 and others added 8 commits July 17, 2024 08:58

Enable CI for Fast DDS v3

4cd1eb4

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

Migrate fastdds_statistics_backend to Fast DDS 3

f238672

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Fix HelloWorldExample compilation

bdbcb28

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Fix error in callbacks overriting

3ef2ce7

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Add documentation

61376f3

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Exclude topic_types folder in doxygen-config

26c3740

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Update documentation

1eb4bf7

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Refs #21302: Fix DiscoveryServers in Monitor

c3a62ab

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur force-pushed the feature/fastdds-migration branch from 43dcd63 to c3a62ab Compare July 17, 2024 07:12

Carlosespicur had a problem deploying to codecov July 17, 2024 07:13 — with GitHub Actions Failure

Refs #21302: Update DataWriter Callback

6cea9d6

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

rsanchez15 changed the title ~~Fast DDS statistics backend migration to Fast DDS v3.0~~ [21302] Fast DDS statistics backend migration to Fast DDS v3.0 Jul 17, 2024

Carlosespicur had a problem deploying to codecov July 17, 2024 08:39 — with GitHub Actions Failure

Carlosespicur had a problem deploying to codecov July 19, 2024 07:01 — with GitHub Actions Failure

Carlosespicur force-pushed the feature/fastdds-migration branch from 063b3ca to 6a21a24 Compare July 19, 2024 11:15

Carlosespicur had a problem deploying to codecov July 19, 2024 11:15 — with GitHub Actions Failure

Refs #21302: Refactor backend tests

5350035

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur force-pushed the feature/fastdds-migration branch from 6a21a24 to 5350035 Compare July 19, 2024 19:23

Carlosespicur had a problem deploying to codecov July 19, 2024 19:23 — with GitHub Actions Failure

Refs #21302: Add missing type_object_registry() method in DomainParti…

c11627f

…cipantFactory mock class Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur had a problem deploying to codecov July 22, 2024 07:41 — with GitHub Actions Failure

Refs #21302: Fix InitMonitor tests

38459e7

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur temporarily deployed to codecov July 22, 2024 08:39 — with GitHub Actions Inactive

Carlosespicur temporarily deployed to codecov July 23, 2024 06:20 — with GitHub Actions Inactive

Refs #21302: Change mock TypeObjectRegistry

fae5037

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur had a problem deploying to codecov July 31, 2024 11:13 — with GitHub Actions Failure

Carlosespicur had a problem deploying to codecov July 31, 2024 13:54 — with GitHub Actions Failure

Carlosespicur had a problem deploying to codecov July 31, 2024 14:21 — with GitHub Actions Failure

Carlosespicur had a problem deploying to codecov July 31, 2024 14:37 — with GitHub Actions Failure

Carlosespicur mentioned this pull request Aug 1, 2024

[21446] Fast DDS Monitor refactor: Fast DDS v3 compatibility eProsima/Fast-DDS-monitor#227

Merged

Refs #21302: Regenerate types with Gen v4.0.0

2920fad

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso temporarily deployed to codecov August 8, 2024 09:30 — with GitHub Actions Inactive

Carlosespicur requested a review from rsanchez15 August 21, 2024 11:25

This was referenced Aug 27, 2024

[21458] Add IDL format to topic entities #245

Merged

[21459] Add IDL view eProsima/Fast-DDS-monitor#230

Merged

Carlosespicur added the first-to-merge label Aug 27, 2024

rsanchez15 added this to the v2.0.0 milestone Aug 27, 2024

JesusPoderoso mentioned this pull request Aug 27, 2024

Enable CI for Fast DDS v3 #244

Closed

This comment was marked as resolved.

Sign in to view

JesusPoderoso requested changes Aug 28, 2024

View reviewed changes

test/dds/communication_old/CMakeLists.txt Outdated Show resolved Hide resolved

Carlosespicur temporarily deployed to codecov August 29, 2024 07:59 — with GitHub Actions Inactive

Refs #21302: Add review comments

e6e3a3b

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur force-pushed the feature/fastdds-migration branch from 1442afe to e6e3a3b Compare August 29, 2024 10:19

Carlosespicur had a problem deploying to codecov August 29, 2024 10:19 — with GitHub Actions Error

Carlosespicur had a problem deploying to codecov August 29, 2024 10:20 — with GitHub Actions Error

Carlosespicur temporarily deployed to codecov August 29, 2024 10:34 — with GitHub Actions Inactive

JesusPoderoso requested changes Aug 29, 2024

View reviewed changes

Refs #21302: uncrustify

11c97e8

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

Carlosespicur force-pushed the feature/fastdds-migration branch from 5a7279e to 11c97e8 Compare August 29, 2024 12:28

Carlosespicur temporarily deployed to codecov August 29, 2024 12:28 — with GitHub Actions Inactive

JesusPoderoso approved these changes Aug 29, 2024

View reviewed changes

JesusPoderoso merged commit b71a4f1 into main Sep 2, 2024
19 of 26 checks passed

JesusPoderoso deleted the feature/fastdds-migration branch September 2, 2024 06:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21302] Fast DDS statistics backend migration to Fast DDS v3.0 #239

[21302] Fast DDS statistics backend migration to Fast DDS v3.0 #239

Carlosespicur commented Jul 9, 2024 •

edited by JesusPoderoso

Loading

This comment was marked as resolved.

This comment was marked as resolved.

JesusPoderoso left a comment

JesusPoderoso left a comment

JesusPoderoso commented Sep 2, 2024

[21302] Fast DDS statistics backend migration to Fast DDS v3.0 #239

[21302] Fast DDS statistics backend migration to Fast DDS v3.0 #239

Conversation

Carlosespicur commented Jul 9, 2024 • edited by JesusPoderoso Loading

This comment was marked as resolved.

This comment was marked as resolved.

JesusPoderoso left a comment

Choose a reason for hiding this comment

JesusPoderoso left a comment

Choose a reason for hiding this comment

JesusPoderoso commented Sep 2, 2024

Carlosespicur commented Jul 9, 2024 •

edited by JesusPoderoso

Loading