[22353] Use correct algorithm strings on PermissionsToken and IdentityToken #5450

MiguelCompany · 2024-11-29T10:12:49Z

Description

This PR changes the strings transmitted in dds.cert.algo, dds.ca.algo, and dds.perm_ca.algo to the ones
specified in DDS-SEC-1.1.

In order to provide interoperability with legacy implementations, a new transmit_algorithms_as_legacy sub-property has been added to the builtin plugins configuration properties.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
- Related documentation PR: [22353] Document new transmit_algorithms_as_legacy on builtin security plugins Fast-DDS-docs#974
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Mario-DL

LGTM, just docs pending

Mario-DL · 2024-12-11T15:15:55Z

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

mergify · 2024-12-11T15:16:02Z

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

#5483 [22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450) has been created for branch 3.1.x
#5484 [22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450) has been created for branch 3.0.x
#5482 [22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450) has been created for branch 2.14.x
#5485 [22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450) has been created for branch 2.10.x but encountered conflicts

…5450) * Refs #19925. Add conversion methods for token algorithms. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on PKIDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on Permissions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add doxygen documentation to new methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 971f120)

…5450) * Refs #19925. Add conversion methods for token algorithms. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on PKIDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on Permissions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add doxygen documentation to new methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 971f120) # Conflicts: # test/blackbox/common/BlackboxTestsSecurity.cpp

…5450) (#5483) * Refs #19925. Add conversion methods for token algorithms. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on PKIDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on Permissions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add doxygen documentation to new methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 971f120) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

…5450) * Refs #19925. Add conversion methods for token algorithms. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on PKIDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on Permissions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add doxygen documentation to new methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 971f120)

…5450) (#5482) * Refs #19925. Add conversion methods for token algorithms. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on PKIDH. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Configure legacy transmission on Permissions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add blackbox test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #19925. Add doxygen documentation to new methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 971f120) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added 5 commits November 29, 2024 10:13

Refs #19925. Add conversion methods for token algorithms.

5f9173e

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #19925. Configure legacy transmission on PKIDH.

07e7bd9

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #19925. Configure legacy transmission on Permissions.

8eca90f

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #19925. Add blackbox test.

87d92dc

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #19925. Add doxygen documentation to new methods.

d3ab484

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added needs-review PR that is ready to be reviewed doc-pending Issue or PR which is pending to be documented labels Nov 29, 2024

MiguelCompany added this to the v3.2.0 milestone Nov 29, 2024

MiguelCompany requested review from richiprosima and removed request for richiprosima November 29, 2024 18:06

github-actions bot added the ci-pending PR which CI is running label Nov 29, 2024

MiguelCompany requested a review from Mario-DL December 2, 2024 12:45

Mario-DL approved these changes Dec 4, 2024

View reviewed changes

Mario-DL removed the needs-review PR that is ready to be reviewed label Dec 4, 2024

MiguelCompany mentioned this pull request Dec 11, 2024

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins eProsima/Fast-DDS-docs#974

Merged

8 tasks

MiguelCompany removed the doc-pending Issue or PR which is pending to be documented label Dec 11, 2024

MiguelCompany merged commit 971f120 into master Dec 11, 2024
31 checks passed

MiguelCompany deleted the bugfix/19925 branch December 11, 2024 15:20

This was referenced Dec 11, 2024

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974) eProsima/Fast-DDS-docs#976

Open

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450) #5485

Open

This was referenced Dec 11, 2024

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974) eProsima/Fast-DDS-docs#977

Open

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974) eProsima/Fast-DDS-docs#978

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken #5450

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken #5450

MiguelCompany commented Nov 29, 2024 •

edited by Mario-DL

Loading

Mario-DL left a comment •

edited

Loading

Mario-DL commented Dec 11, 2024

mergify bot commented Dec 11, 2024 •

edited

Loading

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken #5450

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken #5450

Conversation

MiguelCompany commented Nov 29, 2024 • edited by Mario-DL Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL left a comment • edited Loading

Choose a reason for hiding this comment

Mario-DL commented Dec 11, 2024

mergify bot commented Dec 11, 2024 • edited Loading

✅ Backports have been created

MiguelCompany commented Nov 29, 2024 •

edited by Mario-DL

Loading

Mario-DL left a comment •

edited

Loading

mergify bot commented Dec 11, 2024 •

edited

Loading