DDS refactor #21
DDS refactor #21
Conversation
Signed-off-by: jparisu <javierparis@eprosima.com>
|
Build status: |
There was a problem hiding this comment.
LAN_settings_options.png image does not have the TCP option selected. This image is shown both in the First steps section as in the TCP one. I think that being used in the TCP section the TCP checkbox should appear selected.
Also, I think we should clarify that if no transport is selected, the builtin_transports are enabled (that corresponds to UDP).
| @@ -66,7 +66,10 @@ The following image shows server and client settings: | |||
| * On the server side, the *WAN IP* field contains the server's router IP address, i.e. i.e. the Router S IP address | |||
There was a problem hiding this comment.
| * On the server side, the *WAN IP* field contains the server's router IP address, i.e. i.e. the Router S IP address | |
| * On the server side, the *WAN IP* field contains the server's router IP address, i.e. the Router S IP address |
| .. figure:: /01-figures/tcp_wan_server.png | ||
| :alt: WAN Server settings options | ||
| :align: center | ||
|
|
||
| .. figure:: /01-figures/tcp_client.png | ||
| :alt: WAN Client settings options | ||
| :align: center |
There was a problem hiding this comment.
I suggest changing the order this figures are shown. In the text first the client side is described and then the server side, but the images follow the opposite order.
docs/first_steps/first_steps.rst
Outdated
|
|
||
| - **Intraprocess:** Allow Intraprocess delivery when two Participants run in the same process. | ||
|
|
||
| - **Data SHaring:** Allow Data Sharing delivery when two Participants run in the same process. |
There was a problem hiding this comment.
| - **Data SHaring:** Allow Data Sharing delivery when two Participants run in the same process. | |
| - **Data Sharing:** Allow Data Sharing delivery when two Participants run in the same process. |
I suggest adding a link to the Fast DDS documentation in all these new options so the user can have easy access to a more in-depth explanation of the option.
docs/first_steps/first_steps.rst
Outdated
| @@ -160,6 +160,12 @@ The user can customize several aspects of Shapes Demo operation: | |||
|
|
|||
| + Push the *Start* button in order to resume Shapes Demo operation. | |||
|
|
|||
| - **Shared Memory Transport:** Fast DDS transport using Shared Memory Segment for Participants running in the same | |||
There was a problem hiding this comment.
I am not sure why but when generating the documentation locally, this option is shown in a blue box. Can you check in your side if it is something happening only on my side?
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
|
Build status: |
Signed-off-by: jparisu <javierparis@eprosima.com>
|
Build status: |
Signed-off-by: jparisu <javierparis@eprosima.com>
|
Build status: |
Signed-off-by: jparisu javierparis@eprosima.com